Repository navigation
fix(tests): purge deleted tests, bill their storage, and record versions as loaded - #8858
Conversation
…ons as loaded - Retention cleanup removes an expired test's row before its source file, which its foreign key blocked, and treats test sources as billed so their bytes are released. - A run records each workflow's deployment, and a draft's timestamp, as the executor loads it, so an edit or redeploy mid-run no longer makes the run look current. - Organization-chat workspace submenus leave tests out, like the composer. - Open test opens a new tab on web; doc fixes for hook inheritance and mockSampleOutput. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
|
The latest updates on your projects. Learn more about Vercel for GitHub. |
|
|
@greptile review |
There was a problem hiding this comment.
All reported issues were addressed across 13 files
Reply with feedback, questions, or to request a fix.
Turn on auto-fix | Re-trigger cubic
|
Reading it after the load let an edit landing in between look tested; the snapshot from before the load can only err toward stale. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
|
@greptile review |
Addresses the workflow-test review comments on the v0.9.17 release PR (#8853).
Changes
workflow_testrow still referenced it, so the foreign key rejected the delete on every run. Cleanup now removes expired test rows (their runs cascade) in the same transaction, before the file.workspacecontext as unbilled.testfiles now go through the billed path, which releases their versions and decrements the payer.currentWorkflowon its delegation origin) throughenterWorkflow, and the session records each draft'supdatedAtat that point.mockSampleOutputwording.Verification
background/cleanup-soft-deletes.integration.tsagainst real Postgres: an expired test, its run, and its source are purged, a live one is kept, and workspace + payer storage drop by the source's bytes. It fails on the pre-fix cleanup.updatedAt) and deployed (active deployment ids).lint:check,check:audits, and the executor / workflow-tests / cleanup unit suites pass.Companion PRs
🤖 Generated with Claude Code