Skip to content

chore(tests): remove the seven quarantined integration suites #8953

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
waleedlatif1 merged 1 commit into from
Oct 13, 2026
Merged

chore(tests): remove the seven quarantined integration suites #8953

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions .claude/rules/sim-testing.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -48,8 +48,8 @@ contracts, and demonstrated regressions.
those checks. Isolate with a unique schema or generated IDs, and clean up in `afterAll`.
- Integration files run one at a time against one shared database. A new `*.integration.ts` is
picked up by CI with no workflow change, and the run writes the JSON report configured in
`vitest.shared.ts`, which CI uploads. Never add a passing suite to the quarantine list in
`apps/sim/vitest.config.ts`.
`vitest.shared.ts`, which CI uploads. Never exclude a failing suite from the run in
`apps/sim/vitest.config.ts`: fix it or delete it.
- `bun run test:integration` starts disposable Postgres and Redis containers, provisions the schema,
and runs both workspaces; pass filenames to narrow the `apps/sim` run.

Expand Down
4 changes: 2 additions & 2 deletions .cursor/rules/sim-testing.mdc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -46,8 +46,8 @@ contracts, and demonstrated regressions.
those checks. Isolate with a unique schema or generated IDs, and clean up in `afterAll`.
- Integration files run one at a time against one shared database. A new `*.integration.ts` is
picked up by CI with no workflow change, and the run writes the JSON report configured in
`vitest.shared.ts`, which CI uploads. Never add a passing suite to the quarantine list in
`apps/sim/vitest.config.ts`.
`vitest.shared.ts`, which CI uploads. Never exclude a failing suite from the run in
`apps/sim/vitest.config.ts`: fix it or delete it.
- `bun run test:integration` starts disposable Postgres and Redis containers, provisions the schema,
and runs both workspaces; pass filenames to narrow the `apps/sim` run.

Expand Down
14 changes: 0 additions & 14 deletions apps/sim/lib/credential-groups/enrollments.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1348,20 +1348,6 @@ async function completeResolvedCredentialGroupEnrollment(
})
}

/** Resolves the private, server-only context bound to a public enrollment link and option. */
export async function getCredentialGroupOAuthContext(
token: string,
optionId: string
): Promise<CredentialGroupOAuthContext | null> {
const row = await resolvePublicEnrollmentRowByIdentity({
invitationTokenHash: hashInvitationToken(token),
})
if (!row) return null
const option = row.options.find((candidate) => candidate.id === optionId)
if (!option || option.status !== 'active') return null
return credentialGroupOAuthContextFromRow(row, option)
}

export async function getAuthorizedCredentialGroupOAuthContext(
identity: PublicCredentialGroupEnrollmentIdentity,
optionId: string
Expand Down
Loading
Loading