Skip to content

fix(logs): keep retryable resume refusals internal and log deploy-path config rejections at warn - #9691

Merged
waleedlatif1 merged 1 commit into
stagingfrom
improvement/webhook-resume-final-review
Nov 5, 2026
Merged

waleedlatif1 merged 1 commit into
stagingfrom
improvement/webhook-resume-final-review

Conversation

@waleedlatif1

Copy link
Copy Markdown
Collaborator

Summary

Type of Change

  • Bug fix

Testing

  • biome check on both changed files; type-check, audits, and tests run in CI

Checklist

  • Code follows project style guidelines
  • Self-reviewed my changes
  • Tests added/updated and passing (new tests pass the test-audit authoring gate)
  • No new warnings introduced
  • I confirm that I have read and agree to the terms outlined in the Contributor License Agreement (CLA)

@vercel

vercel Bot commented Nov 5, 2026

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

1 Skipped Deployment
Project Deployment Actions Updated
docs Skipped Skipped Nov 5, 2026 1:49am UTC

Request Review

@greptile-apps

greptile-apps Bot commented Nov 5, 2026 •

Copy link
Copy Markdown
Contributor

RetriggerView in GreptileConfidence Score: 5/5

[Low impact] This PR appears safe to merge.

Summary

This PR aligns two logging paths without changing response statuses or cleanup.

  • Resume requests keep retryable refusals classified as internal failures.
  • Webhook deploys log rejected trigger settings as warnings.

No actionable issues found. No tests were run during this review.

Reviews (1) · Last reviewed commit: "fix(logs): keep retryable resume refusal..." · Reviewed by Greptile

@cubic-dev-ai cubic-dev-ai Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No issues found across 2 files

Confidence score: 5/5

  • Automated review surfaced no issues in the provided summaries.
  • No files require special attention.

Turn on auto-fix | Re-trigger cubic

@waleedlatif1
waleedlatif1 merged commit 85e2fd8 into staging Nov 5, 2026
62 checks passed
@waleedlatif1
waleedlatif1 deleted the improvement/webhook-resume-final-review branch November 5, 2026 01:55

This branch was previously deployed

1 inactive deployment
Preview — 4a59d7f9 Deployed Nov 5, 2026 by vercel[bot]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant