Show translated titles in lookup admin tables and label tree payload#369
Show translated titles in lookup admin tables and label tree payload#369level09 wants to merge 13 commits into
Conversation
…ude translation fields in label tree payload
|
Important Review skippedAuto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
…apsed paths in autocomplete
…owser and CDN caches on release
…tead of session lang
…ns-display # Conflicts: # enferno/templates/layout.html
| for label in self.labels: | ||
| labels_json.append({"id": label.id, "title": label.title}) | ||
| labels_json.append( | ||
| {"id": label.id, "title": label.title, "title_ar": label.title_ar} |
There was a problem hiding this comment.
Question: should we add path and path_ar here too? So we can implement the "Full label paths, without the clutter" feature
There was a problem hiding this comment.
@apodacaduron agreed. and pushed in f8c187f
Thanks for catching this.
There was a problem hiding this comment.
@level09 hey, we might need path and path_ar on Actor Profile labels too. Actor profiles render labels in the actor drawer, and I think those label objects may still be missing the path fields.
2 participants
Summary
title_ar,comments,comments_arinLabel.build_tree: the tree view feeds the edit dialog from this payload, and without these fields saving from tree view silently wiped a label's translation and comments (from_jsondefaults them to empty)title_artoSource.to_dictand a Title (AR) field to the source edit dialog; the column existed and is searchable (Search translated titles in lookup typeahead endpoints #365) but was neither visible nor editableTest plan
uv run pytest tests/test_lookup_crud.py(217 passed)