Always use the current interpreter for test_python_version #56
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Instead of searching the PATH for “python,” use sys.executable to get the Python interpreter parameter for the virtual environment in this test. This keeps the test from failing in environments where there is no “python” on the PATH, e.g. on Fedora Linux where only “python3” is present in the RPM build environment (without the python-unversioned-command package).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Instead of searching the
PATHforpython, usesys.executableto get the Python interpreter parameter for the virtual environment in this test. This keeps the test from failing in environments where there is nopythonon thePATH, e.g. on Fedora Linux where onlypython3is present in the RPM build environment (without thepython-unversioned-commandpackage).