Skip to content

Refactor#9

Merged
skid-dev merged 2 commits intomainfrom
refactor
Apr 1, 2026
Merged

Refactor#9
skid-dev merged 2 commits intomainfrom
refactor

Conversation

@skid-dev
Copy link
Copy Markdown
Owner

@skid-dev skid-dev commented Apr 1, 2026

Do things yes

💤

@skid-dev skid-dev requested a review from Copilot April 1, 2026 11:16
@skid-dev skid-dev merged commit c8c6d2c into main Apr 1, 2026
5 checks passed
Copy link
Copy Markdown

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Refactors the launcher content-script structure and build configuration for the Chrome extension.

Changes:

  • Renames/splits launcher entrypoints in webpack.config.cjs (homepage vs shortcut launcher scripts).
  • Moves launcher CSS into src/content/modules/launcher/launcher_styles.css and updates build copy patterns.
  • Adjusts relative imports in launcher content scripts after file moves.

Reviewed changes

Copilot reviewed 3 out of 4 changed files in this pull request and generated 1 comment.

File Description
webpack.config.cjs Updates webpack entries/copy patterns; adds performance hints suppression.
src/content/modules/launcher/launcher_styles.css Adds module-scoped launcher styling (including Ctrl+K overlay styles).
src/content/modules/launcher/launch_shortcut.ts Updates imports for new module location.
src/content/modules/launcher/launch_homepage.ts Updates imports for new module location.
Comments suppressed due to low confidence (2)

webpack.config.cjs:24

  • The content entry was removed/renamed, but the background injector still executes content.js (see src/background/events/injects/launcher.ts:13). With the current entries, the build will no longer emit dist/content.js, so the launcher inject on the homepage will fail at runtime. Reintroduce a content entry (aliasing the new homepage launcher script) or update the injector to load launcher_homepage.js.
        entry: {
            popup: "./src/popup/popup.ts",
            background: "./src/background/background.ts",
            launcher_homepage: "./src/content/modules/launcher/launch_homepage.ts",
            launcher_shortcut: "./src/content/modules/launcher/launch_shortcut.ts",
            get_textbooks: "./src/content/modules/launcher/getters/get_textbooks.ts",
            inject_css_tools: "./src/content/inject_css_tools.ts",
            news_search_main: "./src/content/modules/news_search/news_search.ts",
            display_history: "./src/content/modules/post_history_tracking/content.ts",

src/content/modules/launcher/launch_shortcut.ts:3

  • launcher is imported but never used. Keeping this import also risks bundling background-only code (that uses chrome.scripting) into the content-script bundle unnecessarily. Remove the unused import.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@skid-dev skid-dev deleted the refactor branch April 1, 2026 11:24
@github-actions
Copy link
Copy Markdown

github-actions bot commented Apr 1, 2026

🎉 This PR is included in version 1.1.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants