fix(hermes): preserve artifact blocks when converting to native content - #64
Merged
NishantJoshi00 merged 2 commits intoSep 25, 2026
Merged
Conversation
NishantJoshi00
approved these changes
Sep 25, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
When exporting or converting transcripts with
Block::Artifactto Hermes format (Hermes::from_common), artifact blocks were completely dropped.In
src/harness/hermes.rs,native_contentonly filtered forBlock::TextandBlock::Image. AnyBlock::Artifactwas matched by_ => Noneand discarded. If a message consisted solely of an artifact (or text + artifact), the artifact content was completely omitted from the resulting Hermes messagecontent.Other harnesses without native artifact storage (such as Pi, Cursor, Fx, Grok, and Codex) retain artifact content using
artifact.display_text().Changes
native_contentinsrc/harness/hermes.rs:artifact.display_text()and append it to the text blocks joined by\n.{"type": "text", "text": artifact.display_text()}for anyBlock::Artifact.from_common_preserves_artifactsintests/integration/hermes.rschecking both user and assistant turns.