Conversation
Contributor
Author
|
Second commit just extends coverage: the moved tests were all Windows-gated, so Linux CI exercised none of the shared logic. Added a platform-neutral test (vanished child matches, same-prefix sibling doesn't) plus verified the wasm32 check passes with the code now living in the lib crate. No behavior change. |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue: #72
What changed and why?
query --cwd(#51) filtered with its own naivepath_under: plaincanonicalizeplus bytestarts_with. On Windows that misses verbatim\\?\-prefixed cwds and case variants, the exact bug #67 fixed forlist --cwd.The
under_dircore (verbatim-strip, case-fold compare, lenientcanonicalize) moves from the CLI to new
src/paths.rs, and both filtersroute through it. Its unit tests move along;
querygains a regressiontest that failed before the fix (0 hits) and passes after.
Checks:
cargo test -p txcript(65 lib + 225 integration) andcargo test -p txcript-cli --lib(103) all pass;fmt --checkandclippy --all-targetsclean on both crates. Also verified through thebuilt binary:
listandquerywith a differently-cased--cwdnow agree.