Skip to content

fix(search): share under_dir with query cwd filter - #73

Open
Drix10 wants to merge 2 commits into
skillsynchq:mainfrom
Drix10:fix/search-cwd-windows-parity
Open

Drix10 wants to merge 2 commits into
skillsynchq:mainfrom
Drix10:fix/search-cwd-windows-parity

Conversation

@Drix10

@Drix10 Drix10 commented Sep 26, 2026

Copy link
Copy Markdown
Contributor

Issue: #72

What changed and why?

query --cwd (#51) filtered with its own naive path_under: plain
canonicalize plus byte starts_with. On Windows that misses verbatim
\\?\-prefixed cwds and case variants, the exact bug #67 fixed for
list --cwd.

The under_dir core (verbatim-strip, case-fold compare, lenient
canonicalize) moves from the CLI to new src/paths.rs, and both filters
route through it. Its unit tests move along; query gains a regression
test that failed before the fix (0 hits) and passes after.

Checks: cargo test -p txcript (65 lib + 225 integration) and
cargo test -p txcript-cli --lib (103) all pass; fmt --check and
clippy --all-targets clean on both crates. Also verified through the
built binary: list and query with a differently-cased --cwd now agree.

@Drix10

Drix10 commented Sep 26, 2026

Copy link
Copy Markdown
Contributor Author

Second commit just extends coverage: the moved tests were all Windows-gated, so Linux CI exercised none of the shared logic. Added a platform-neutral test (vanished child matches, same-prefix sibling doesn't) plus verified the wasm32 check passes with the code now living in the lib crate. No behavior change.

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant