Restrict channel will will respond to in Slack#352
Open
Ashex wants to merge 1 commit intoskoczen:masterfrom
Ashex:slack_channels
Open
Restrict channel will will respond to in Slack#352Ashex wants to merge 1 commit intoskoczen:masterfrom Ashex:slack_channels
Ashex wants to merge 1 commit intoskoczen:masterfrom
Ashex:slack_channels
Conversation
Owner
|
So, I like the efficiency idea behind this - but since slack allows adhoc joins (and people seem to be using them), I'm not sure it makes sense to explicitly restrict Will's ability to respond to That said, this certainly should be documented a whole lot better. |
Collaborator
Author
|
I think workspace tokens will make it a lot easier to manage as the permission of scope can be locked down. Currently apps can be added to any channel and we have no control over that, the static channel ACL is simply my solution. My other idea was to maintain this list inside redis so that an empowered individual (command locked down with user acl) could update the room restriction on the fly. |
Collaborator
Author
|
Hi @skoczen Let me know what changes you'd like to see and I'll implement them. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a half decent implementation of the hipchat rooms restriction. This works by checking the channel a message from the RTM stream is coming from, it is discarded if it does not come from an allowed list.
I believe this also reduces the processing load from handling all the messages.