feat: implement ISpanParsable<T>#378
Draft
skwasjer wants to merge 1 commit into
Draft
Conversation
For time being the impl. is private, until we can commit to a complete API change (deprecating IbanParser). The behavior is nuanced, because the IbanParser accepts a custom registry whereas this impl. uses the default registry. We either change this via a static settable registry, or don't bother, but this is a choice that must be made before we can make this public and phase out IbanParser.
|
6 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
For the time being the impl. is private, until we can commit to a complete API change (deprecating
IbanParser).The behavior is also different, because the
IbanParseraccepts a custom registry (via the ctor) whereas this impl. uses the default registry. We either change this via a static settable registry, or don't bother, but this is a choice that must be made before we can make this public and phase out IbanParser.See also #133 and #138
Relates to #148