Tighten tolerances in event finding routines#561
Open
JoshPaterson wants to merge 1 commit intoskyfielders:masterfrom
Open
Tighten tolerances in event finding routines#561JoshPaterson wants to merge 1 commit intoskyfielders:masterfrom
JoshPaterson wants to merge 1 commit intoskyfielders:masterfrom
Conversation
Contributor
Author
|
This test is failing at line 68: python-skyfield/skyfield/tests/test_almanac_searches.py Lines 56 to 68 in a30a3e5 Fixing it will have to wait until tomorrow. If it's obvious to you feel free to make whatever changes are necessary. |
Member
There's no problem with waiting til tomorrow! See what you can do about the test first; I'll probably first respond about broader issues before diving in to specific tests. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #559.
This PR tightens tolerances as discussed in #559. It's enough to fix the particular bugs in that issue, and makes that kind of bug less likely but doesn't completely prevent it. Do you think these tolerances should be decreased more so errors are even less likely?
Ideally there would be a more thorough fix that would make those kind of bugs impossible rather than just unlikely. I'll keep thinking about it, but for now this is enough to get @bmatthiesen's scripts working.