chore(deps): bump tokio/serde/clap/regex/uuid/futures/syn and friends#571
Merged
Conversation
read_optional_wide's snapshot_device_object ends up passed to CreateFileW in the Broker (a LocalSystem service) to open the actual snapshot volume; a lossy UTF-16 substitution on malformed shim input would silently turn it into a different-but-plausible path instead of surfacing the problem. Switch to String::from_utf16, returning None (already a handled case for every caller) on invalid encoding. Mark the one genuinely display-only lossy decode (a tracing log field in uffs-broker's VSS helper, where the actual session lookup already keys off the raw bytes) with the anti-pattern gate's AUDIT-OK(bytes) escape hatch instead. Pre-existing anti_pattern_gate.sh failure, unrelated to this branch's dependency bumps; fixed here rather than left broken.
Version-bumps: tokio 1.52.3->1.53.1, futures 0.3.32->0.3.33, serde 1.0.228->1.0.229, serde_json 1.0.150->1.0.151, toml 1.1.2->1.1.3, bitflags 2.13.0->2.13.1, bytemuck 1.25.1->1.25.2, thiserror 2.0.18-> 2.0.19, anyhow 1.0.103->1.0.104, clap 4.6.1->4.6.3, regex 1.13.0-> 1.13.1, globset 0.4.18->0.4.19, which 8.0.4->8.0.5, uuid 1.23.5->1.24.0. Cargo.lock updated via targeted `cargo update -p <crate>` per bumped pin (not a full relock) to keep the transitive blast radius to exactly the ~30 packages these ranges actually touch. cargo-vet: certified every newly-unvetted crate at safe-to-deploy -- scoped per-package trust grants for already-trusted-publisher patch/ minor bumps (dtolnay: anyhow/serde/serde_core/serde_derive/thiserror/ thiserror-impl; epage: clap/clap_derive/clap_builder/toml/toml_writer; BurntSushi: regex/globset/regex-automata; Darksonn: tokio), plus real delta-diff certifications (reviewed for unsafe/capability changes) for the rest, including a full manual review of syn's 2.0->3.0 major bump despite the large diff, given its foundational role. `cargo vet prune` removed the exemptions these certifications superseded. cargo deny check: clean (pre-existing duplicate-version warnings only).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Cargo.lockupdated via targetedcargo update -p <crate>per bumped pin (not a full relock), keeping the transitive blast radius to exactly the ~30 packages these ranges touch.safe-to-deploy-- scoped per-package publisher-trust grants for already-trusted-publisher patch/minor bumps, plus real delta-diff review (checked for unsafe/capability changes) for the rest, including a full manual review of syn's 2.0->3.0 major bump given its foundational role.cargo vet pruneremoved the exemptions these certifications superseded.anti_pattern_gate.shfailure found while validating this branch: a lossy UTF-16 decode inuffs-vss-requestorwhose output (snapshot_device_object) ends up passed toCreateFileWin the LocalSystem-privileged Broker -- switched to strictString::from_utf16(returnsNone, already a handled case, on malformed input) instead of silently substituting. A second, genuinely display-only lossy decode inuffs-broker's VSS helper got the gate'sAUDIT-OK(bytes)marker instead, since the real session lookup there already keys off the raw bytes.Test plan
cargo vet check/--locked-- Vetting Succeededcargo deny check-- advisories/bans/licenses/sources okjust go(full local gate suite) -- greengit pushpre-push gate (fmt, drift checks, vet-audit-discipline, lint-ci(-windows), doc-tests, tests, smoke, deny) -- all 22 gates green