Skip to content

fix(mft): demote IOCP-fallback chain messages from WARN to INFO #579

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
githubrobbi merged 1 commit into from
Jul 23, 2026
Merged

fix(mft): demote IOCP-fallback chain messages from WARN to INFO #579

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 11 additions & 2 deletions crates/uffs-mft/src/reader/index_read.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -803,7 +803,13 @@ impl MftReader {
// 1. Open `X:\$MFT` as a file (filesystem-mediated)
// 2. Re-open volume with FILE_FLAG_NO_BUFFERING (bypasses cache manager,
// direct device I/O)
warn!(
// INFO, not WARN: the cascade below is designed,
// automatically-handled resilience — a normal run
// stays quiet (WARN-default subscribers show
// nothing) and `-v`/verbose reveals the chain when
// debugging. If every fallback fails too, the `?`
// propagates a real error.
info!(
volume = %self.volume,
error = %iocp_err,
"⚠️ IOCP inline read failed — trying fallback strategies"
Expand Down Expand Up @@ -920,7 +926,10 @@ impl MftReader {
return result;
}
Err(err) => {
warn!(
// INFO for the same reason as the IOCP-failure line: an
// intermediate rung of the handled fallback chain, not an
// operator-actionable warning.
info!(
volume = %self.volume,
error = %err,
"⚠️ Fallback 1 ($MFT file) failed — trying unbuffered volume I/O"
Expand Down
Loading