chore: add default app icon#75
Open
srtaalej wants to merge 1 commit into
Open
Conversation
Co-Authored-By: Claude <svc-devxp-claude@slack-corp.com>
WilliamBergamin
requested changes
May 11, 2026
Contributor
WilliamBergamin
left a comment
WilliamBergamin
left a comment
There was a problem hiding this comment.
Thanks for working on this, I'm not sure if this change should be applied to this project, the project is not setup to work with the CLI adding the icon will have no effect 😅
Member
|
@WilliamBergamin I'm curious to open an adjacent PR for default CLI support? We have a solid |
Contributor
|
@zimeg yess we can introduce support for the CLI in this project 💯 Even if it add background time to CI I think its fine, if the time becomes a problem in the future then we will address it |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
assets/icon.pngTest plan
slack run --experiment set-iconand confirm the icon appears on the app