fix(receivers): allow null for AwsEventV1.multiValueQueryStringParameters#3019
Open
muskaannnr wants to merge 1 commit into
Open
fix(receivers): allow null for AwsEventV1.multiValueQueryStringParameters#3019muskaannnr wants to merge 1 commit into
muskaannnr wants to merge 1 commit into
Conversation
…ters AWS API Gateway sends null for multiValueQueryStringParameters when no multi-value query params are present. This matches @types/aws-lambda's APIGatewayProxyEvent and fixes the type error when passing that type directly to the handler returned by AwsLambdaReceiver. Fixes slackapi#2939
🦋 Changeset detectedLatest commit: 8506b53 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
AWS API Gateway sends
nullformultiValueQueryStringParameterswhen no multi-value query params are present. This matches@types/aws-lambda'sAPIGatewayProxyEventand fixes the type error when passing that type directly to the handler returned byAwsLambdaReceiver.Fixes #2939
Summary
AwsEventV1.multiValueQueryStringParameterswas typed as non-nullable (Record<string, string[] | undefined>), but AWS actually sendsnullfor this field when there are no multi-value query string parameters. This caused a type incompatibility when passing anAPIGatewayProxyEvent(from@types/aws-lambda) directly to the handler returned byAwsLambdaReceiver.start()ortoHandler(), requiring an unnecessaryas AwsEventV1cast.This PR changes the type to
AwsEventMultiValueStringParameters | nullto match reality and the official AWS types. A tsd type test is also added to prevent regression.Requirements