-
Notifications
You must be signed in to change notification settings - Fork 233
feat: add agents.conversations.* methods #1647
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
29 commits
Select commit
Hold shift + click to select a range
5069f8f
feat: add agents.conversations.* code channel methods
zimeg a9f095b
docs: trim scope + channel notes from agents.conversations.* javadoc
zimeg 8ab3843
chore(web-api): commit regenerated rate_limit_tiers for agents.conver…
zimeg 3bc9336
refactor(methods): address review on agents.conversations
zimeg 22357d2
test(methods): make agents.conversations remote test a full lifecycle
zimeg de2b06a
test(methods): clean up the agents.conversations remote canvas + asserts
zimeg e14612e
feat(methods): model agents.conversations response fields from live c…
zimeg 44fa563
test(methods): remove the agents.conversations view by its returned v…
zimeg 643a88c
test(methods): exercise agents.conversations views with an HTML view
zimeg 878f12c
refactor(methods): order agents.conversations before agents.sessions
zimeg 9d6eff1
refactor(methods): drop class javadoc from agents.conversations respo…
zimeg 0310ebf
refactor(methods): trim agents.conversations request class javadoc to…
zimeg 2c62833
docs(methods): align agents.conversations request field docs with doc…
zimeg 43efb59
feat(methods): add typed args for agents.conversations complex fields
zimeg d42ca35
refactor(methods): drop title/status from agents.conversations.setPro…
zimeg abeb9b4
test(methods): use Arrays.asList for JDK 8 compatibility
zimeg 2a13114
fix(methods): trim listViews View to the fields the API returns
zimeg 360fded
test: record getCanvas comments as captured instead of a file comment…
zimeg 7ba4762
fix(methods): drop *AsString twins from agents.conversations complex …
zimeg 5717c42
fix: address review on agents.conversations methods
zimeg a3988df
docs: match agents.conversations argument descriptions to the reference
zimeg 4fd812e
feat: add should_escape to agents.conversations.setCommands commands
zimeg 958da6e
feat: add the code_channel repository properties to agents.conversati…
zimeg 32157e2
test: set every code channel property in the agents.conversations rem…
zimeg f15bc87
Revert "test: set every code channel property in the agents.conversat…
zimeg c325b6c
Revert "feat: add the code_channel repository properties to agents.co…
zimeg 7ac65f1
test: record getCanvas comments from an existing canvas with comments
zimeg 36f1262
test: cover agents.conversations methods with the mock server
zimeg 8a648ff
feat(models): add record_channel, code_channel, and agent_session con…
zimeg File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,7 @@ | ||
| { | ||
| "ok": false, | ||
| "error": "", | ||
| "warning": "", | ||
| "needed": "", | ||
| "provided": "" | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,8 @@ | ||
| { | ||
| "ok": false, | ||
| "channel_id": "C00000000", | ||
| "warning": "", | ||
| "error": "", | ||
| "needed": "", | ||
| "provided": "" | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,29 @@ | ||
| { | ||
| "ok": false, | ||
| "canvas_id": "F00000000", | ||
| "title": "", | ||
| "content": "", | ||
| "comments": [ | ||
| { | ||
| "id": "", | ||
| "ts": "", | ||
| "user_id": "", | ||
| "text": "", | ||
| "quoted_text": "", | ||
| "is_resolved": false, | ||
| "replies": [ | ||
| { | ||
| "ts": "", | ||
| "user_id": "", | ||
| "text": "" | ||
| } | ||
| ], | ||
| "has_more_replies": false | ||
| } | ||
| ], | ||
| "has_more_comments": false, | ||
| "warning": "", | ||
| "error": "", | ||
| "needed": "", | ||
| "provided": "" | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,17 @@ | ||
| { | ||
| "ok": false, | ||
| "error": "", | ||
| "warning": "", | ||
| "needed": "", | ||
| "provided": "", | ||
| "views": [ | ||
| { | ||
| "view_id": "", | ||
| "view_key": "", | ||
| "file_id": "F00000000", | ||
| "label": "", | ||
| "content_version": 12345, | ||
| "date_added": 12345 | ||
| } | ||
| ] | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,9 @@ | ||
| { | ||
| "ok": false, | ||
| "error": "", | ||
| "warning": "", | ||
| "needed": "", | ||
| "provided": "", | ||
| "channel_id": "C00000000", | ||
| "view_id": "" | ||
| } |
9 changes: 9 additions & 0 deletions
9
json-logs/samples/api/agents.conversations.setCanvasContent.json
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,9 @@ | ||
| { | ||
| "ok": false, | ||
| "error": "", | ||
| "warning": "", | ||
| "needed": "", | ||
| "provided": "", | ||
| "canvas_id": "F00000000", | ||
| "sections_changed_count": 12345 | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,9 @@ | ||
| { | ||
| "ok": false, | ||
| "error": "", | ||
| "warning": "", | ||
| "needed": "", | ||
| "provided": "", | ||
| "channel_id": "C00000000", | ||
| "command_count": 12345 | ||
| } |
8 changes: 8 additions & 0 deletions
8
json-logs/samples/api/agents.conversations.setProperties.json
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,8 @@ | ||
| { | ||
| "ok": false, | ||
| "error": "", | ||
| "warning": "", | ||
| "needed": "", | ||
| "provided": "", | ||
| "channel_id": "C00000000" | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,13 @@ | ||
| { | ||
| "ok": false, | ||
| "error": "", | ||
| "warning": "", | ||
| "needed": "", | ||
| "provided": "", | ||
| "channel_id": "C00000000", | ||
| "view_id": "", | ||
| "file_id": "F00000000", | ||
| "content_version": 12345, | ||
| "type": "", | ||
| "canvas_id": "F00000000" | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
📚 note: Aligning with docs soon but right now this seems right
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍 Agreed. This sample matches what the API returns today, and we can follow up if the docs land on a different shape.