fix: add missing response types for #2459 (files.uploadV2) and #2550 (conversations.setTopic) - #2751
Open
dajiaohuang wants to merge 1 commit into
Open
dajiaohuang wants to merge 1 commit into
dajiaohuang wants to merge 1 commit into
Conversation
…#2550 - Add FilesUploadV2Response type for files.uploadV2 method (issue slackapi#2459) - Add missing 'latest' field and Latest interface to ConversationsSetTopicResponse (issue slackapi#2550) - All manual additions marked with 'Manual addition pending regeneration' comment
|
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR adds manual fixes for missing TypeScript response types as described in issues #2459 and #2550:
FilesUploadV2Responsetype for thefiles.uploadV2method. Previously this returned genericWebAPICallResult, causing TypeScript errors when accessing thefilesproperty on responses.channel.latestin returned object #2550: Added missinglatestfield (andLatestinterface) to theChannelinterface inConversationsSetTopicResponse, matching the actual API response structure.All manual additions are marked with the comment
// Manual addition pending regenerationas requested, since response types are normally auto-generated.Changes
FilesUploadV2Response.tsinsrc/types/response/src/types/response/index.tssrc/methods.tsto import and useFilesUploadV2Responsefor theuploadV2method bindingsrc/WebClient.tsto importFilesUploadV2Responseand use it as the return type forfilesUploadV2methodlatest?: Latestfield andLatestinterface toConversationsSetTopicResponse.tsRequirements