fix: request name reverts after renaming an open request panel - #24
Merged
Conversation
Renaming a request from the sidebar updated storage and the panel title but never told the already-open webview, so its stale in-memory name got posted back and reverted the rename on the next Send/Save.
slverma
pushed a commit
that referenced
this pull request
Jul 20, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Problem
If a request panel is open and you rename that request from the sidebar, sending (or saving) the request afterward silently restores the old name.
Root cause
SidebarProvider.renameRequestpersists the new name to storage and updates the panel title viaRequestEditorProvider.updatePanelTitle, but never notifies the already-open webview. The webview's React state keeps the stale name in itsconfigobject. Both "Send Request" and "Save" post that fullconfigback to the extension host, which writes it straight to storage and the sidebar tree — so the stale name overwrites the rename.Fix
updatePanelTitlenow also posts arequestRenamedmessage to the webview.RequestContext.tsxhandles it by updatingconfig.namein state, keeping the webview in sync so subsequent saves carry the correct name.Files changed
src/providers/RequestEditorProvider.tssrc/webview/request/RequestContext.tsxTest plan
npx tsc --noEmitpasses