Repository navigation
Conversation
Fixes smarie#95. Merge preset keyword defaults before call-time values in regular, generator and async-generator wrappers. Preserve the inner partial. Five regressions fail before the fix. Full suite: 102 passed, 1 skipped on Python 3.12.14; git diff --check clean. No new lint diagnostics relative to the original implementation. Assisted-by: OpenAI Codex
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #95.
Nested partials currently overwrite caller keyword arguments with their preset defaults. Copy the presets first and then apply caller arguments, consistently for regular functions, generators, asynchronous functions and the legacy coroutine helper.
Five new regression cases fail on the original source. The final complete suite passes102 tests with one existing skip. Isolated Flake8 checks introduce no diagnostics relative to the baseline; the repository's existing inline-comment configuration cannot be parsed by the current Flake8 tool. Added the changelog entry.
Prepared with Codex assistance; implementation and tests independently reviewed.