Skip to content

fix: quarantine UX improvements and QA testing infrastructure#338

Merged
Dumbris merged 12 commits intomainfrom
fix/quarantine-ux-improvements
Mar 11, 2026
Merged

fix: quarantine UX improvements and QA testing infrastructure#338
Dumbris merged 12 commits intomainfrom
fix/quarantine-ux-improvements

Conversation

@Dumbris
Copy link
Contributor

@Dumbris Dumbris commented Mar 11, 2026

Summary

  • Visual diff for changed tools: Fixed Web UI to fetch and display inline diffs for changed tools (rug pull detection). The diff rendering template existed but data was never fetched — now loadToolApprovals() also calls getToolDiff() for changed tools.
  • Stale quarantine counts: Fixed server list showing stale pending/changed counts after individual tool approvals by refreshing server data via serversStore.fetchServers() after approval.
  • New tool injection test scenario: Added steal_data tool to echo-rugpull server that appears only after rug pull — verifies MCPProxy quarantines brand-new injected tools as "pending".
  • QA testing infrastructure: Two Node.js test MCP servers (malicious + echo-rugpull), automated 18-scenario test script, and self-contained HTML report.

Test plan

  • make build succeeds with frontend changes
  • bash tests/test-quarantine.sh — 18/18 tests passing
  • QT-15/QT-15b: New steal_data tool detected as pending after rug pull
  • Visual diff rendering works for changed tools in Web UI
  • Quarantine counts refresh after individual tool approval
  • Manual verification of Web UI diff display

🤖 Generated with Claude Code

claude added 11 commits March 11, 2026 07:39
Design for end-to-end testing of MCPProxy's quarantine UX across CLI,
REST API, MCP protocol, and Web UI. Includes two test MCP servers
(malicious + rug-pull echo), automated test script, and Chrome
walkthrough plan.

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Semi-automated test plan covering two test MCP servers, 14 test
scenarios across CLI/REST/MCP, Chrome UX walkthrough, and HTML report
generation. Addresses reviewer feedback: HTTP status codes, UX
evaluation checklist, GIF embedding workflow.

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Add README documenting the two test MCP servers (malicious TPA vectors
and rug-pull simulator) and the 16-scenario quarantine test script.
Update test config to enable socket and pre-quarantine servers. Include
generated HTML test report and Chrome UX walkthrough GIF.

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
…ine counts

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
…e fixes

- Add QT-15/QT-15b tests verifying steal_data tool detected as pending
  after rug pull (new tool injection scenario)
- Rebuild frontend with visual diff and stale counts fixes
- Restore minimal test config (mcpproxy auto-expands on run)
- Update HTML report: 18/18 tests passing

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
@cloudflare-workers-and-pages
Copy link

cloudflare-workers-and-pages bot commented Mar 11, 2026

Deploying mcpproxy-docs with  Cloudflare Pages  Cloudflare Pages

Latest commit: 835bd6b
Status: ✅  Deploy successful!
Preview URL: https://1d3d559b.mcpproxy-docs.pages.dev
Branch Preview URL: https://fix-quarantine-ux-improvemen.mcpproxy-docs.pages.dev

View logs

@github-actions
Copy link

github-actions bot commented Mar 11, 2026

📦 Build Artifacts

Workflow Run: View Run
Branch: fix/quarantine-ux-improvements

Available Artifacts

  • archive-darwin-amd64 (25 MB)
  • archive-darwin-arm64 (23 MB)
  • archive-linux-amd64 (14 MB)
  • archive-linux-arm64 (13 MB)
  • archive-windows-amd64 (25 MB)
  • archive-windows-arm64 (22 MB)
  • frontend-dist-pr (0 MB)
  • installer-dmg-darwin-amd64 (28 MB)
  • installer-dmg-darwin-arm64 (25 MB)

How to Download

Option 1: GitHub Web UI (easiest)

  1. Go to the workflow run page linked above
  2. Scroll to the bottom "Artifacts" section
  3. Click on the artifact you want to download

Option 2: GitHub CLI

gh run download 22948770759 --repo smart-mcp-proxy/mcpproxy-go

Note: Artifacts expire in 14 days.

Strip docs/{qa,superpowers} and web/frontend/dist/* changes
from this PR to keep it focused on code fixes and test servers.

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
@Dumbris Dumbris merged commit 7db4016 into main Mar 11, 2026
24 checks passed
@Dumbris Dumbris deleted the fix/quarantine-ux-improvements branch March 11, 2026 11:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants