fix(cli): accept an empty keystore password as valid, not missing - #391
Open
aelmanaa wants to merge 1 commit into
Open
fix(cli): accept an empty keystore password as valid, not missing#391aelmanaa wants to merge 1 commit into
aelmanaa wants to merge 1 commit into
Conversation
|
You must have Developer access to commit code to Chainlink Labs on Vercel. If you contact an administrator and receive Developer access, commit again to see your changes. Learn more: https://vercel.com/docs/accounts/team-members-and-roles/access-roles#team-level-roles |
|
👋 aelmanaa, thanks for creating this pull request! To help reviewers, please consider creating future PRs as drafts first. This allows you to self-review and make any final changes before notifying the team. Once you're ready, you can mark it as "Ready for review" to request feedback. Thanks! |
Coverage Report |
andrevmatos
approved these changes
Sep 1, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request improves support for passwordless keystores (those encrypted with an empty string as a password) in the CLI and its documentation. Previously, the CLI could not unlock such keystores in non-interactive mode because it treated an empty password as missing. The changes ensure that an empty string is accepted as a valid password, only treating an unset environment variable as missing. Comprehensive tests and documentation updates are included.
Bug Fixes and Feature Improvements:
--no-interactive. [1] [2] [3]Testing:
ccip-cli/src/providers/evm.test.tsto verify correct handling of passwordless keystores and empty passwords for Foundry, JSON, and Hardhat wallets.Documentation:
Changelog: