NONEVM-97: Add setConfig and clearConfig unit tests#363
Merged
Conversation
Contributor
|
👋 Fletch153, thanks for creating this pull request! To help reviewers, please consider creating future PRs as drafts first. This allows you to self-review and make any final changes before notifying the team. Once you're ready, you can mark it as "Ready for review" to request feedback. Thanks! |
Fletch153
force-pushed
the
NONEVM-97/add-setconfig-unit-tests
branch
from
dc4ba21 to
4084feb
Compare
Port EVM KeystoneForwarder_SetConfigTest suite to Move for both platform and platform_secondary forwarder contracts.
Fletch153
force-pushed
the
NONEVM-97/add-setconfig-unit-tests
branch
from
4084feb to
f9fa942
Compare
yashnevatia
approved these changes
Mar 5, 2026
archseer
approved these changes
Mar 6, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
KeystoneForwarder_SetConfigTestsuite to Move for bothplatformandplatform_secondaryforwarder contractssetConfigtests: success, max oracles, upsert, multiple DONs, multiple versions, not owner, f=0, excess oracles, insufficient oraclesclearConfigtests: success, get-after-clear, isolation, not owner, nonexistent configgenerate_oracle_set_with_paramshelper for flexible test setupTest plan
aptos move testpasses forplatformcontractaptos move testpasses forplatform_secondarycontract