Open
Conversation
tt-cll
reviewed
Jan 31, 2026
| // EVM allows empty extraArgs | ||
| return nil, nil | ||
| case chain_selectors.FamilyTon: | ||
| // TODO: maybe for 1.6 we should look up the source adapter and use a 1.6 method to encode? would be good to avoid other chain SDKs |
Collaborator
There was a problem hiding this comment.
agree with the comment. I think when we see chain packages importing other chain packages, it's an anti-pattern. It brings us closer to tight coupling.
archseer
requested review from
0xAustinWang,
agusaldasoro,
b-gopalswami,
chris-de-leon-cll,
ogtownsend,
tt-cll and
winder
|
RensR
reviewed
Feb 13, 2026
| - name: getAllAuthorizedCallers | ||
| access: public | ||
|
|
||
| - contract_name: FeeQuoter |
Collaborator
There was a problem hiding this comment.
nit: can we maintain the versioning ordering, meaning 1.6.3 goes at the top
RensR
reviewed
Feb 13, 2026
| @@ -61,7 +61,7 @@ mockery: $(mockery) ## Install mockery. | |||
|
|
|||
| .PHONY: extract-bytecode-abi | |||
| extract-bytecode-abi: ## Extract bytecode and abi from versioned gobindings to bytecode and abi directories | |||
Collaborator
There was a problem hiding this comment.
I think we can remove this, it's part of the wrapper generation and doesn't have to be called on its own. It being part of the wrappers means it can never produce outdated results.
I had already removed it on the develop branch.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Requires: