Draft
Conversation
ogtownsend
force-pushed
the
ogt/support-solana-devenv
branch
from
7bf9c99 to
e829f78
Compare
archseer
reviewed
Mar 9, 2026
Comment on lines
+81
to
+85
| CantonConfigs util.OpaqueConfig `toml:"canton_configs"` | ||
|
|
||
| // SolanaConfigs is the map of chain selectors to Solana configurations to pass onto the verifier, | ||
| // only used in standalone mode and if Solana is enabled. | ||
| SolanaConfigs util.OpaqueConfig `toml:"solana_configs"` |
There was a problem hiding this comment.
@makramkd WDYT if we type this as
Configs map[string]util.OpaqueConfig `toml:"configs"`
with string mapping to chain family? This FooConfigs approach leaked through from the relayer implementation in core where each family's config was strongly typed
Collaborator
There was a problem hiding this comment.
Oh yeah that sounds like a better approach eh
Collaborator
There was a problem hiding this comment.
Also means you don't have to update devenv to support a new family, which is preferred.
ogtownsend
commented
Mar 13, 2026
Comment on lines
-861
to
-863
| if in.Blockchains[i].Type == blockchain.TypeCanton { | ||
| continue | ||
| } |
Author
There was a problem hiding this comment.
@makramkd is this really needed? I don't see Pricer in any of the canton env tomls. Would love to clean up the if <chainFamily>...s wherever possible :D
ogtownsend
force-pushed
the
ogt/support-solana-devenv
branch
from
288cd09 to
cf32cd3
Compare
|
Code coverage report:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Corresponding ccip-solana PR: https://github.com/smartcontractkit/chainlink-ccip-solana/pull/14