Executor service refactor and bootstrap by faisal-chainlink · Pull Request #870 · smartcontractkit/chainlink-ccv

faisal-chainlink · 2026-03-09T23:24:27Z

This PR adds a devenv service bootstrap path for the executor. This matches what has been done for the verifier.

…difier

…ce factory

github-actions · 2026-03-10T21:37:41Z

Code coverage report:

Package	`main`	`feature/executor-bootstrap`	diff
github.com/smartcontractkit/chainlink-ccv/aggregator	48.05%	48.06%	+0.01%
github.com/smartcontractkit/chainlink-ccv/bootstrap	51.13%	51.13%	+0.00%
github.com/smartcontractkit/chainlink-ccv/cmd	0.00%	0.00%	+0.00%
github.com/smartcontractkit/chainlink-ccv/committee	0.00%	100.00%	+100.00%
github.com/smartcontractkit/chainlink-ccv/common	0.00%	52.89%	+52.89%
github.com/smartcontractkit/chainlink-ccv/executor	0.00%	46.95%	+46.95%
github.com/smartcontractkit/chainlink-ccv/indexer	0.00%	36.79%	+36.79%
github.com/smartcontractkit/chainlink-ccv/integration	0.00%	43.59%	+43.59%
github.com/smartcontractkit/chainlink-ccv/pkg	0.00%	100.00%	+100.00%
github.com/smartcontractkit/chainlink-ccv/pricer	0.00%	0.00%	+0.00%
github.com/smartcontractkit/chainlink-ccv/protocol	0.00%	64.82%	+64.82%
github.com/smartcontractkit/chainlink-ccv/verifier	0.00%	38.41%	+38.41%

WARNING: go tool cover failed for coverage_target.out
cover: open /home/runner/_work/chainlink-ccv/chainlink-ccv/cmd/executor/main.go: no such file or directory

faisal-chainlink · 2026-03-10T22:00:43Z

Needs more edits around documentation and configuration

makramkd

Excellent start! Main points:

Do we still need the legacy mode? I noticed that main.go didn't switch to use bootstrap.Run, is that for another PR?
Key generation is still happening manually in devenv, I think we should switch that to use the keystore like the verifier
Some common code can probably be factored out

makramkd · 2026-03-11T13:14:04Z

build/devenv/evm/impl.go

+	case chainsel.FamilyStellar:
+		return serializeExtraArgsV3(opts)


Haha, another point of registration needed? 🤔

We have it on 1.6 and it'd be nice to bring over: https://github.com/smartcontractkit/chainlink-ccip/blob/28f9affca9218f1c594b0ae0ef26523811841032/deployment/testadapters/adapters.go#L108-L112

The ExtraArgOpt approach is a bit clunky though since each implementation ends up with a loop like this so cciptestinterfaces.MessageOptions seems nicer: https://github.com/smartcontractkit/chainlink-ccip/blob/28f9affca9218f1c594b0ae0ef26523811841032/chains/evm/deployment/v1_6_0/testadapter/test_adapter.go#L258-L272
https://github.com/smartcontractkit/chainlink-ccip/blob/28f9affca9218f1c594b0ae0ef26523811841032/chains/solana/deployment/v1_6_0/testadapter/test_adapter.go#L388-L405

(note that on 1.6 it's source chain encoded so there's more code)

Something like this?

GetExtraArgs(receiver []byte, opts cciptestinterfaces.MessageOptions) ([]byte, error)

Receiver leaks through because solana needs to derive some custom accounts based on it

makramkd · 2026-03-11T13:14:56Z

build/devenv/services/executor/base.go

+	// TransmitterPrivateKey is used in standalone mode for transaction signing.
+	TransmitterPrivateKey string `toml:"transmitter_private_key"`


Is this still being used even after bootstrapping? We should rely on a key generated by the keystore instead if so.

makramkd · 2026-03-11T13:15:37Z

build/devenv/services/executor/base.go

+
+// GenerateConfigWithBlockchainInfos combines the pre-generated config with blockchain infos
+// for standalone mode deployment.
+func (v *Input) GenerateConfigWithBlockchainInfos(blockchainInfos map[string]*blockchain.Info) ([]byte, error) {


Still being used?

makramkd · 2026-03-11T13:16:19Z

build/devenv/services/executor/base.go

+// NewStandalone creates a standalone executor (legacy mode, no bootstrap/JD).
+func NewStandalone(in *Input, blockchainOutputs []*ctfblockchain.Output) (*Output, error) {


Is there a reason you think we should keep this around?

makramkd · 2026-03-11T13:17:26Z

build/devenv/services/executor/base.go

+func generateTransmitterPrivateKey() (string, error) {
+	// TODO: not chain agnostic.
+	pk, err := crypto.GenerateKey()
+	if err != nil {
+		return "", err
+	}
+	return hex.EncodeToString(crypto.FromECDSA(pk)), nil
+}
+
+// SetTransmitterPrivateKey sets the transmitter private key for the provided execs array.
+func SetTransmitterPrivateKey(execs []*Input) ([]*Input, error) {
+	for _, exec := range execs {
+		pk, err := generateTransmitterPrivateKey()
+		if err != nil {
+			return nil, fmt.Errorf("failed to generate transmitter private key: %w", err)
+		}
+		exec.TransmitterPrivateKey = pk
+	}
+	return execs, nil
+}


IMO we should remove these

makramkd · 2026-03-11T13:23:33Z

executor/Dockerfile

 # Then copy the rest of the source and build
 COPY . .
-WORKDIR /cmd/executor
+WORKDIR /cmd/executor/standalone


Ditto here, don't need standalone suffix

makramkd · 2026-03-11T13:23:41Z

executor/Dockerfile.dev

 # Then copy the rest of the source
 COPY . .
-WORKDIR /app/cmd/executor
+WORKDIR /app/cmd/executor/standalone


Don't need standalone suffix

makramkd · 2026-03-11T13:26:22Z

executor/load.go

+// LoadConfigWithBlockchainInfos decodes the executor config from the job spec
+// into a strongly-typed map[string]*T. The type T is chosen by the caller (e.g.
+// blockchain.Info for EVM). Strict decode is applied: any unknown key in the
+// config (including under blockchain_infos.<selector>) causes an error.
+// The returned Configuration has defaults applied via GetNormalizedConfig.
+func LoadConfigWithBlockchainInfos[T any](spec JobSpec) (*Configuration, map[string]*T, error) {


This dups what we have for commit verifier right? I guess the only difference is the return value Configuration instead of Config.

Maybe we can factor out a common method, we'll need to add a second generic type param for the return value though, wdyt?

type cfgWithBlockchainInfos[T any, U any] struct { U BlockchainInfos map[string]*T `toml:"blockchain_infos"` } func LoadConfigWithBlockchainInfos[T any, U any](spec JobSpec) (*U, map[string]*T, error) {

makramkd · 2026-03-11T13:27:01Z

executor/load.go

+	normalized, err := decodeTarget.GetNormalizedConfig()
+	if err != nil {
+		return nil, nil, fmt.Errorf("failed to normalize executor config: %w", err)
+	}


Ah I just realized that this is executor specific, hmm...

Only thing I can think of is that we can call this after we decode, doesn't seem like it has to be part of decoding, but not too caught up on it.

makramkd · 2026-03-11T13:27:46Z

cmd/executor/standalone/main.go

Also, were you thinking of adding the bootstrapped version in a follow up PR?

The current setup here wraps this (standalone) as a bootstrapped version. In Stellar, it's being setup with bootstrap.Run (like this) just like the verifier

ah nvm, I just realized this was about the the main.go in here

faisal-chainlink added 5 commits March 10, 2026 03:22

update devenv to package executor as a configurable service with a mo…

0d5e0c3

…difier

refactor executor cmd entrypoint to allow other modes and add a servi…

9cc7322

…ce factory

formatting

2831573

update devenv environment to handle bootstrapped executor

b1afb71

edit devenv environment

984aa30

faisal-chainlink requested review from FelixFan1992 and makramkd March 10, 2026 18:54

faisal-chainlink added 3 commits March 11, 2026 00:42

extend evm devenv impl

b054f63

lints

3cf207c

more lints

d349f3a

faisal-chainlink marked this pull request as ready for review March 10, 2026 21:58

faisal-chainlink requested review from a team and skudasov as code owners March 10, 2026 21:58

makramkd reviewed Mar 11, 2026

View reviewed changes

		case chainsel.FamilyStellar:
		return serializeExtraArgsV3(opts)

		// TransmitterPrivateKey is used in standalone mode for transaction signing.
		TransmitterPrivateKey string `toml:"transmitter_private_key"`

		// NewStandalone creates a standalone executor (legacy mode, no bootstrap/JD).
		func NewStandalone(in Input, blockchainOutputs []ctfblockchain.Output) (*Output, error) {

Conversation

faisal-chainlink commented Mar 9, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

github-actions bot commented Mar 10, 2026

Uh oh!

faisal-chainlink commented Mar 10, 2026

Uh oh!

makramkd left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

archseer Mar 11, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

faisal-chainlink commented Mar 9, 2026 •

edited

Loading

archseer Mar 11, 2026 •

edited

Loading