add field to mark requests as external for solana service (#2066) by Unheilbar · Pull Request #2117 · smartcontractkit/chainlink-common

Unheilbar · 2026-06-02T21:58:39Z

add field to mark requests as external for solana service
fix format
update comments

Requires

Supports

* add field to mark requests as external for solana service * fix format * update comments --------- Co-authored-by: Silas Lenihan <32529249+silaslenihan@users.noreply.github.com>

github-actions · 2026-06-02T22:00:00Z

⚠️ API Diff Results - `github.com/smartcontractkit/chainlink-common`

⚠️ Breaking Changes (6)

`pkg/capabilities/v2/chain-capabilities/solana/server.ClientCapability` (1)

GetProgramAccounts — ➕ Added

`pkg/chains/solana.SolanaClient` (1)

GetProgramAccounts — ➕ Added

`pkg/types.SolanaService` (1)

mustEmbedUnimplementedClient — ➕ Added

`pkg/types/chains/solana.Client` (3)

GetProgramAccounts — ➕ Added
GetProgramAccounts — ➕ Added
mustEmbedUnimplementedClient — ➕ Added

✅ Compatible Changes (76)

`pkg/capabilities/v2/chain-capabilities/solana` (8)

ConvertGetProgramAccountsReplyToProto — ➕ Added
ConvertGetProgramAccountsRequestFromProto — ➕ Added
GetProgramAccountsOpts — ➕ Added
GetProgramAccountsReply — ➕ Added
GetProgramAccountsRequest — ➕ Added
KeyedAccount — ➕ Added
RPCFilter — ➕ Added
RPCFilterMemcmp — ➕ Added

`pkg/capabilities/v2/chain-capabilities/solana.(*FilterLogTriggerRequest)` (1)

GetIncludeReverted — ➕ Added

`pkg/capabilities/v2/chain-capabilities/solana.FilterLogTriggerRequest` (1)

IncludeReverted — ➕ Added

`pkg/capabilities/v2/chain-capabilities/solana/server.ClientCapability` (1)

GetProgramAccounts — ➕ Added

`pkg/chains/solana` (23)

ConvertGetAccountInfoRequestFromProto — ➕ Added
ConvertGetAccountInfoRequestToProto — ➕ Added
ConvertGetProgramAccountsOptsFromProto — ➕ Added
ConvertGetProgramAccountsOptsToProto — ➕ Added
ConvertGetProgramAccountsReplyFromProto — ➕ Added
ConvertGetProgramAccountsReplyToProto — ➕ Added
ConvertGetProgramAccountsRequestFromProto — ➕ Added
ConvertGetProgramAccountsRequestToProto — ➕ Added
ConvertKeyedAccountFromProto — ➕ Added
ConvertKeyedAccountToProto — ➕ Added
ConvertRPCFilterFromProto — ➕ Added
ConvertRPCFilterMemcmpFromProto — ➕ Added
ConvertRPCFilterMemcmpToProto — ➕ Added
ConvertRPCFiltersFromProto — ➕ Added
ConvertRPCFiltersToProto — ➕ Added
ConvertRPCFilterToProto — ➕ Added
GetProgramAccountsOpts — ➕ Added
GetProgramAccountsReply — ➕ Added
GetProgramAccountsRequest — ➕ Added
KeyedAccount — ➕ Added
RPCFilter — ➕ Added
RPCFilterMemcmp — ➕ Added
Solana_GetProgramAccounts_FullMethodName — ➕ Added

`pkg/chains/solana.(*GetAccountInfoWithOptsRequest)` (1)

GetIsExternal — ➕ Added

`pkg/chains/solana.(*GetMultipleAccountsWithOptsRequest)` (1)

GetIsExternal — ➕ Added

`pkg/chains/solana.(*GetTransactionRequest)` (1)

GetIsExternal — ➕ Added

`pkg/chains/solana.(*SimulateTXRequest)` (1)

GetIsExternal — ➕ Added

`pkg/chains/solana.GetAccountInfoWithOptsRequest` (1)

IsExternal — ➕ Added

`pkg/chains/solana.GetMultipleAccountsWithOptsRequest` (1)

IsExternal — ➕ Added

`pkg/chains/solana.GetTransactionRequest` (1)

IsExternal — ➕ Added

`pkg/chains/solana.SimulateTXRequest` (1)

IsExternal — ➕ Added

`pkg/chains/solana.SolanaServer` (1)

GetProgramAccounts — ➕ Added

`pkg/chains/solana.UnimplementedSolanaServer` (1)

GetProgramAccounts — ➕ Added

`pkg/http` (3)

GetResponseSizeLimit — ➕ Added
LimitedTransport — ➕ Added
WithResponseSizeLimit — ➕ Added

`pkg/types.UnimplementedSolanaService` (1)

UnimplementedSolanaClient — ➕ Added

`pkg/types/chains/solana` (8)

ClientMustEmbed — ➕ Added
GetProgramAccountsOpts — ➕ Added
GetProgramAccountsReply — ➕ Added
GetProgramAccountsRequest — ➕ Added
KeyedAccount — ➕ Added
RPCFilter — ➕ Added
RPCFilterMemcmp — ➕ Added
UnimplementedSolanaClient — ➕ Added

`pkg/types/chains/solana.GetAccountInfoRequest` (1)

IsExternal — ➕ Added

`pkg/types/chains/solana.GetMultipleAccountsRequest` (1)

IsExternal — ➕ Added

`pkg/types/chains/solana.GetTransactionRequest` (1)

IsExternal — ➕ Added

`pkg/types/chains/solana.SimulateTXRequest` (1)

IsExternal — ➕ Added

`pkg/types/chains/solana.UnimplementedSolanaClient` (10)

GetAccountInfoWithOpts — ➕ Added
GetBalance — ➕ Added
GetBlock — ➕ Added
GetFeeForMessage — ➕ Added
GetMultipleAccountsWithOpts — ➕ Added
GetProgramAccounts — ➕ Added
GetSignatureStatuses — ➕ Added
GetSlotHeight — ➕ Added
GetTransaction — ➕ Added
SimulateTX — ➕ Added

`pkg/types/mocks` (4)

SolanaService_GetProgramAccounts_Call — ➕ Added
SolanaService_mustEmbedUnimplementedClient_Call — ➕ Added
SolanaServiceShim — ➕ Added
WrapSolanaService — ➕ Added

`pkg/types/mocks.(*SolanaService)` (1)

GetProgramAccounts — ➕ Added

`pkg/types/mocks.(*SolanaService_Expecter)` (1)

GetProgramAccounts — ➕ Added

📄 View full apidiff report

* pipe get program accounts * add nil check test cases * add mustEmbedUnimplementedClient * handle nil filters * fix tests * run generate * fix mocks

add field to mark requests as external for solana service (#2066)

609e75f

* add field to mark requests as external for solana service * fix format * update comments --------- Co-authored-by: Silas Lenihan <32529249+silaslenihan@users.noreply.github.com>

silaslenihan previously approved these changes Jun 2, 2026

View reviewed changes

Unheilbar and others added 3 commits June 4, 2026 14:33

bump protos

c521c58

make tidy

1169e6d

Plex 2406/pipe get program accounts (#2126)

a45c846

* pipe get program accounts * add nil check test cases * add mustEmbedUnimplementedClient * handle nil filters * fix tests * run generate * fix mocks

Unheilbar dismissed silaslenihan’s stale review via a45c846 June 4, 2026 18:53

Unheilbar and others added 2 commits June 4, 2026 16:35

Merge branch 'bump-protos' into feature/solcap-read_trigger

08c3cd7

add proto conversions for GetProgramAccounts (#2128)

27a72f7

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

add field to mark requests as external for solana service (#2066)#2117

add field to mark requests as external for solana service (#2066)#2117
Unheilbar wants to merge 6 commits into
mainfrom
feature/solcap-read_trigger

Unheilbar commented Jun 2, 2026

Uh oh!

github-actions Bot commented Jun 2, 2026 •

edited

Loading

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Conversation

Unheilbar commented Jun 2, 2026

Requires

Supports

Uh oh!

github-actions Bot commented Jun 2, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

⚠️ API Diff Results - github.com/smartcontractkit/chainlink-common

⚠️ Breaking Changes (6)

pkg/capabilities/v2/chain-capabilities/solana/server.ClientCapability (1)

pkg/chains/solana.SolanaClient (1)

pkg/types.SolanaService (1)

pkg/types/chains/solana.Client (3)

✅ Compatible Changes (76)

pkg/capabilities/v2/chain-capabilities/solana (8)

pkg/capabilities/v2/chain-capabilities/solana.(*FilterLogTriggerRequest) (1)

pkg/capabilities/v2/chain-capabilities/solana.FilterLogTriggerRequest (1)

pkg/capabilities/v2/chain-capabilities/solana/server.ClientCapability (1)

pkg/chains/solana (23)

pkg/chains/solana.(*GetAccountInfoWithOptsRequest) (1)

pkg/chains/solana.(*GetMultipleAccountsWithOptsRequest) (1)

pkg/chains/solana.(*GetTransactionRequest) (1)

pkg/chains/solana.(*SimulateTXRequest) (1)

pkg/chains/solana.GetAccountInfoWithOptsRequest (1)

pkg/chains/solana.GetMultipleAccountsWithOptsRequest (1)

pkg/chains/solana.GetTransactionRequest (1)

pkg/chains/solana.SimulateTXRequest (1)

pkg/chains/solana.SolanaServer (1)

pkg/chains/solana.UnimplementedSolanaServer (1)

pkg/http (3)

pkg/types.UnimplementedSolanaService (1)

pkg/types/chains/solana (8)

pkg/types/chains/solana.GetAccountInfoRequest (1)

pkg/types/chains/solana.GetMultipleAccountsRequest (1)

pkg/types/chains/solana.GetTransactionRequest (1)

pkg/types/chains/solana.SimulateTXRequest (1)

pkg/types/chains/solana.UnimplementedSolanaClient (10)

pkg/types/mocks (4)

pkg/types/mocks.(*SolanaService) (1)

pkg/types/mocks.(*SolanaService_Expecter) (1)

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

github-actions Bot commented Jun 2, 2026 •

edited

Loading

⚠️ API Diff Results - `github.com/smartcontractkit/chainlink-common`

`pkg/capabilities/v2/chain-capabilities/solana/server.ClientCapability` (1)

`pkg/chains/solana.SolanaClient` (1)

`pkg/types.SolanaService` (1)

`pkg/types/chains/solana.Client` (3)

`pkg/capabilities/v2/chain-capabilities/solana` (8)

`pkg/capabilities/v2/chain-capabilities/solana.(*FilterLogTriggerRequest)` (1)

`pkg/capabilities/v2/chain-capabilities/solana.FilterLogTriggerRequest` (1)

`pkg/capabilities/v2/chain-capabilities/solana/server.ClientCapability` (1)

`pkg/chains/solana` (23)

`pkg/chains/solana.(*GetAccountInfoWithOptsRequest)` (1)

`pkg/chains/solana.(*GetMultipleAccountsWithOptsRequest)` (1)

`pkg/chains/solana.(*GetTransactionRequest)` (1)

`pkg/chains/solana.(*SimulateTXRequest)` (1)

`pkg/chains/solana.GetAccountInfoWithOptsRequest` (1)

`pkg/chains/solana.GetMultipleAccountsWithOptsRequest` (1)

`pkg/chains/solana.GetTransactionRequest` (1)

`pkg/chains/solana.SimulateTXRequest` (1)

`pkg/chains/solana.SolanaServer` (1)

`pkg/chains/solana.UnimplementedSolanaServer` (1)

`pkg/http` (3)

`pkg/types.UnimplementedSolanaService` (1)

`pkg/types/chains/solana` (8)

`pkg/types/chains/solana.GetAccountInfoRequest` (1)

`pkg/types/chains/solana.GetMultipleAccountsRequest` (1)

`pkg/types/chains/solana.GetTransactionRequest` (1)

`pkg/types/chains/solana.SimulateTXRequest` (1)

`pkg/types/chains/solana.UnimplementedSolanaClient` (10)

`pkg/types/mocks` (4)

`pkg/types/mocks.(*SolanaService)` (1)

`pkg/types/mocks.(*SolanaService_Expecter)` (1)