Skip to content

Added cipherless observation flag for the vault #2123

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
russell-stern wants to merge 2 commits into
base: main
Choose a base branch
from
Draft

Added cipherless observation flag for the vault #2123

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
37d3d84
Added cipherless observation flag for the vault
russell-stern Jun 3, 2026
4292fef
Fixed test
russell-stern Jun 3, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions pkg/settings/cresettings/README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -42,6 +42,7 @@ flowchart
VaultBase64EncodingEnabled[/VaultBase64EncodingEnabled\]:::gate
VaultForceEmptyOCRRounds[/VaultForceEmptyOCRRounds\]:::gate
VaultOptimizationsEnabled[/VaultOptimizationsEnabled\]:::gate
VaultCiphertextlessObservationsEnabled[/VaultCiphertextlessObservationsEnabled\]:::gate
end

subgraph HandleNodeMessage[gatewayHandler.HandleNodeMessage]
Expand Down
1 change: 1 addition & 0 deletions pkg/settings/cresettings/defaults.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,6 +9,7 @@
"VaultBase64EncodingEnabled": "false",
"VaultForceEmptyOCRRounds": "false",
"VaultOptimizationsEnabled": "false",
"VaultCiphertextlessObservationsEnabled": "false",
"GatewayHTTPGlobalRate": "500rps:500",
"GatewayHTTPPerNodeRate": "100rps:100",
"GatewayConfidentialRelayGlobalRate": "50rps:10",
Expand Down
1 change: 1 addition & 0 deletions pkg/settings/cresettings/defaults.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,6 +8,7 @@ PropagateOrgIDInRequestMetadata = 'false'
VaultBase64EncodingEnabled = 'false'
VaultForceEmptyOCRRounds = 'false'
VaultOptimizationsEnabled = 'false'
VaultCiphertextlessObservationsEnabled = 'false'
GatewayHTTPGlobalRate = '500rps:500'
GatewayHTTPPerNodeRate = '100rps:100'
GatewayConfidentialRelayGlobalRate = '50rps:10'
Expand Down
2 changes: 2 additions & 0 deletions pkg/settings/cresettings/settings.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -63,6 +63,7 @@ var Default = Schema{
VaultBase64EncodingEnabled: Bool(false),
VaultForceEmptyOCRRounds: Bool(false),
VaultOptimizationsEnabled: Bool(false),
VaultCiphertextlessObservationsEnabled: Bool(false),
GatewayHTTPGlobalRate: Rate(rate.Limit(500), 500),
GatewayHTTPPerNodeRate: Rate(rate.Limit(100), 100),
GatewayConfidentialRelayGlobalRate: Rate(rate.Limit(50), 10),
Expand Down Expand Up @@ -263,6 +264,7 @@ type Schema struct {
VaultBase64EncodingEnabled Setting[bool]
VaultForceEmptyOCRRounds Setting[bool]
VaultOptimizationsEnabled Setting[bool]
VaultCiphertextlessObservationsEnabled Setting[bool]
GatewayHTTPGlobalRate Setting[config.Rate]
GatewayHTTPPerNodeRate Setting[config.Rate]
GatewayConfidentialRelayGlobalRate Setting[config.Rate]
Expand Down
1 change: 1 addition & 0 deletions pkg/settings/cresettings/settings_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -130,6 +130,7 @@ func TestSchema_Unmarshal(t *testing.T) {
assert.False(t, cfg.VaultBase64EncodingEnabled.DefaultValue)
assert.False(t, cfg.VaultForceEmptyOCRRounds.DefaultValue)
assert.False(t, cfg.VaultOptimizationsEnabled.DefaultValue)
assert.False(t, cfg.VaultCiphertextlessObservationsEnabled.DefaultValue)
assert.Equal(t, config.Rate{Limit: rate.Limit(20), Burst: 7}, cfg.GatewayConfidentialRelayGlobalRate.DefaultValue)
assert.Equal(t, config.Rate{Limit: rate.Limit(4), Burst: 2}, cfg.GatewayConfidentialRelayPerNodeRate.DefaultValue)
assert.Equal(t, 48*time.Hour, cfg.PerOrg.ZeroBalancePruningTimeout.DefaultValue)
Expand Down
Loading