Skip to content

docs(readme): add MCMS adapter update instructions to chain addition guide#722

Merged
graham-chainlink merged 1 commit intomainfrom
ggoh/docs/update-readme-mcms-adapter-instructions
Feb 10, 2026
Merged

docs(readme): add MCMS adapter update instructions to chain addition guide#722
graham-chainlink merged 1 commit intomainfrom
ggoh/docs/update-readme-mcms-adapter-instructions

Conversation

@graham-chainlink
Copy link
Collaborator

@graham-chainlink graham-chainlink commented Feb 10, 2026

Summary

This PR updates the README to include instructions for updating the MCMS adapter when adding a new chain to the framework. This step was previously missing and was highlighted in PR #714 during the Stellar chain integration.

@changeset-bot
Copy link

changeset-bot bot commented Feb 10, 2026

⚠️ No Changeset found

Latest commit: ba61833

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@graham-chainlink graham-chainlink changed the title docs: add MCMS adapter update instructions to chain addition guide docs(readme): add MCMS adapter update instructions to chain addition guide Feb 10, 2026
@graham-chainlink graham-chainlink marked this pull request as ready for review February 10, 2026 02:54
@graham-chainlink graham-chainlink requested a review from a team as a code owner February 10, 2026 02:54
Copilot AI review requested due to automatic review settings February 10, 2026 02:54
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Updates the chain-addition guide to include the missing MCMS adapter update step when integrating a new chain.

Changes:

  • Adds a new “Update MCMS adapter” step with references to chain_access.go and chain_access_test.go
  • Documents the expected interface addition (ChainsFetcher) and an accessor method on ChainAccessAdapter
  • Renumbers the existing “Write comprehensive tests” step accordingly

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Update the README to include instructions for updating the MCMS adapter
when adding a new chain to the framework. This step was previously missing
and was highlighted in PR #714 during the Stellar chain integration.

The new section documents:
- How to update chain/mcms/adapters/chain_access.go with the new chain's
  client accessor method
- How to add the chain getter to the ChainsFetcher interface
- How to update the corresponding test file with test coverage

This ensures developers remember to update MCMS-related code when adding
new chains that support MCMS operations.
@graham-chainlink graham-chainlink force-pushed the ggoh/docs/update-readme-mcms-adapter-instructions branch from 2dc3a32 to ba61833 Compare February 10, 2026 02:57
@cl-sonarqube-production
Copy link

Quality Gate passed Quality Gate passed

Issues
0 New issues
0 Fixed issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarQube

@graham-chainlink graham-chainlink added this pull request to the merge queue Feb 10, 2026
Merged via the queue into main with commit 303b626 Feb 10, 2026
20 checks passed
@graham-chainlink graham-chainlink deleted the ggoh/docs/update-readme-mcms-adapter-instructions branch February 10, 2026 05:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants