Skip to content

Adding MaxGasPrice to GasConfig #256

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
yashnevatia wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Adding MaxGasPrice to GasConfig #256

yashnevatia wants to merge 2 commits into from
+6 −0

Conversation

@yashnevatia
Copy link

@yashnevatia yashnevatia commented Jan 9, 2026 •
edited
Loading

@yashnevatia yashnevatia requested review from a team as code owners January 9, 2026 15:36
@changeset-bot
Copy link

changeset-bot bot commented Jan 9, 2026 •
edited
Loading

⚠️ No Changeset found

Latest commit: 3c03e68

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@github-actions
Copy link

github-actions bot commented Jan 9, 2026

👋 yashnevatia, thanks for creating this pull request!

To help reviewers, please consider creating future PRs as drafts first. This allows you to self-review and make any final changes before notifying the team.

Once you're ready, you can mark it as "Ready for review" to request feedback. Thanks!

@github-actions
Copy link

github-actions bot commented Jan 9, 2026 •
edited
Loading

The latest Buf updates on your PR. Results from workflow Regenerate Protobuf Files / buf (pull_request).

BuildFormatLintBreakingUpdated (UTC)
✅ passed✅ passed✅ passed⏩ skippedJan 9, 2026, 3:38 PM

This was referenced Jan 12, 2026
Draft
Draft
jmank88
jmank88 reviewed Feb 6, 2026
View reviewed changes
cre/capabilities/blockchain/evm/v1alpha/client.proto
uint64 gas_limit = 1;
// Maximum gas price (in wei) the user is willing to pay for this transaction.
// If not specified, the value configured in GasEstimator will be used.
optional values.v1.BigInt max_gas_price = 2;
Copy link

@jmank88 jmank88 Feb 6, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are there other PRs demonstrating usage of this field? Because enforcing it strictly normally conflicts with gas bumping.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jmank88 jmank88 jmank88 left review comments

@ChrisAmora ChrisAmora Awaiting requested review from ChrisAmora

@MStreet3 MStreet3 Awaiting requested review from MStreet3

At least 1 approving review is required to merge this pull request.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@yashnevatia @jmank88