Skip to content

adding workflowTag tests #223

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
fernandezlautaro wants to merge 1 commit into from
Closed

adding workflowTag tests #223

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions cmd/workflow/deploy/deploy.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -169,6 +169,10 @@ func (h *handler) ValidateInputs() error {
return fmt.Errorf("failed to initialize validator: %w", err)
}

if h.inputs.WorkflowTag == "" {
h.inputs.WorkflowTag = h.inputs.WorkflowName
}

if err := validate.Struct(h.inputs); err != nil {
return validate.ParseValidationErrors(err)
}
Expand Down
23 changes: 23 additions & 0 deletions cmd/workflow/deploy/deploy_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -44,6 +44,29 @@ func TestWorkflowDeployCommand(t *testing.T) {
wantKey: "Inputs.WorkflowName",
wantDetail: "WorkflowName must be non-empty, no longer than 64 characters, and contain only letters (a-z, A-Z), numbers (0-9), dashes (-), and underscores (_): this_is_a_really_long_workflow_name_that_exceeds_the_maximum_allowed_length_of_64_chars",
},
{
name: "Workflow Name Fine but too long for tag",
inputs: Inputs{
WorkflowName: "workflow_tag_name_longer_than_32_bytes",
WorkflowOwner: "0x4c0883a69102937d6234146e38a6aefbf95944c6e4d4013a6d287e4d739e7f9b",
DonFamily: "test_label",
},
wantErr: true,
wantKey: "Inputs.WorkflowTag",
wantDetail: "WorkflowTag must be a maximum of 32 characters in length",
},
{
name: "WorkflowTag too long",
inputs: Inputs{
WorkflowName: "valid_workflow",
WorkflowOwner: "0x4c0883a69102937d6234146e38a6aefbf95944c6e4d4013a6d287e4d739e7f9b",
DonFamily: "test_label",
WorkflowTag: "workflow_tag_name_longer_than_32_bytes",
},
wantErr: true,
wantKey: "Inputs.WorkflowTag",
wantDetail: "WorkflowTag must be a maximum of 32 characters in length",
},
{
name: "Invalid Workflow Owner - Missing 0x Prefix",
inputs: Inputs{
Expand Down
Loading