CRE-4368 Add mtls auth to typescript sdk by cedric-cordenier · Pull Request #265 · smartcontractkit/cre-sdk-typescript

cedric-cordenier · 2026-06-05T12:12:04Z

No description provided.

github-actions · 2026-06-05T12:12:24Z

👋 cedric-cordenier, thanks for creating this pull request!

To help reviewers, please consider creating future PRs as drafts first. This allows you to self-review and make any final changes before notifying the team.

Once you're ready, you can mark it as "Ready for review" to request feedback. Thanks!

github-actions · 2026-06-05T12:18:50Z

⚠️ Template Compatibility Failures

This PR breaks one or more templates in cre-templates (tested against cre-templates:main).

========================================================
Results: 34 passed, 1 failed
========================================================

Failed templates:
  ❌ workflow-ts/por

========================================================
Failure Details
========================================================

❌ workflow-ts/por — typecheck
--------
$ tsc --noEmit
../contracts/evm/ts/generated/DataFeedsCache.ts(8,8): error TS2307: Cannot find module 'viem' or its corresponding type declarations.
../contracts/evm/ts/generated/DataFeedsCache.ts(9,35): error TS2307: Cannot find module 'viem' or its corresponding type declarations.
../contracts/evm/ts/generated/DataFeedsCache.ts(19,8): error TS2307: Cannot find module '@chainlink/cre-sdk' or its corresponding type declarations.
../contracts/evm/ts/generated/DataFeedsCache.ts(1247,29): error TS7006: Parameter 't' implicitly has an 'any' type.
../contracts/evm/ts/generated/DataFeedsCache.ts(1259,29): error TS7006: Parameter 't' implicitly has an 'any' type.
../contracts/evm/ts/generated/DataFeedsCache.ts(1272,35): error TS7006: Parameter '_' implicitly has an 'any' type.
../contracts/evm/ts/generated/DataFeedsCache.ts(1272,38): error TS7006: Parameter 'i' implicitly has an 'any' type.
../contracts/evm/ts/generated/DataFeedsCache.ts(1297,31): error TS7006: Parameter 't' implicitly has an 'any' type.
../contracts/evm/ts/generated/DataFeedsCache.ts(1318,29): error TS7006: Parameter 't' implicitly has an 'any' type.
../contracts/evm/ts/generated/DataFeedsCache.ts(1329,29): error TS7006: Parameter 't' implicitly has an 'any' type.
../contracts/evm/ts/generated/DataFeedsCache.ts(1341,35): error TS7006: Parameter '_' implicitly has an 'any' type.
../contracts/evm/ts/generated/DataFeedsCache.ts(1341,38): error TS7006: Parameter 'i' implicitly has an 'any' type.
../contracts/evm/ts/generated/DataFeedsCache.ts(1366,31): error TS7006: Parameter 't' implicitly has an 'any' type.
../contracts/evm/ts/generated/DataFeedsCache.ts(1387,29): error TS7006: Parameter 't' implicitly has an 'any' type.
../contracts/evm/ts/generated/DataFeedsCache.ts(1399,29): error TS7006: Parameter 't' implicitly has an 'any' type.
../contracts/evm/ts/generated/DataFeedsCache.ts(1412,35): error TS7006: Parameter '_' implicitly has an 'any' type.
../contracts/evm/ts/generated/DataFeedsCache.ts(1412,38): error TS7006: Parameter 'i' implicitly has an 'any' type.
../contracts/evm/ts/generated/DataFeedsCache.ts(1437,31): error TS7006: Parameter 't' implicitly has an 'any' type.
../contracts/evm/ts/generated/DataFeedsCache.ts(1458,29): error TS7006: Parameter 't' implicitly has an 'any' type.
../contracts/evm/ts/generated/DataFeedsCache.ts(1469,29): error TS7006: Parameter 't' implicitly has an 'any' type.
../contracts/evm/ts/generated/DataFeedsCache.ts(1481,35): error TS7006: Parameter '_' implicitly has an 'any' type.
../contracts/evm/ts/generated/DataFeedsCache.ts(1481,38): error TS7006: Parameter 'i' implicitly has an 'any' type.
../contracts/evm/ts/generated/DataFeedsCache.ts(1506,31): error TS7006: Parameter 't' implicitly has an 'any' type.
../contracts/evm/ts/generated/DataFeedsCache.ts(1527,29): error TS7006: Parameter 't' implicitly has an 'any' type.
../contracts/evm/ts/generated/DataFeedsCache.ts(1540,29): error TS7006: Parameter 't' implicitly has an 'any' type.
../contracts/evm/ts/generated/DataFeedsCache.ts(1554,35): error TS7006: Parameter '_' implicitly has an 'any' type.
../contracts/evm/ts/generated/DataFeedsCache.ts(1554,38): error TS7006: Parameter 'i' implicitly has an 'any' type.
../contracts/evm/ts/generated/DataFeedsCache.ts(1579,31): error TS7006: Parameter 't' implicitly has an 'any' type.
../contracts/evm/ts/generated/DataFeedsCache.ts(1600,29): error TS7006: Parameter 't' implicitly has an 'any' type.
../contracts/evm/ts/generated/DataFeedsCache.ts(1612,29): error TS7006: Parameter 't' implicitly has an 'any' type.
../contracts/evm/ts/generated/DataFeedsCache.ts(1625,35): error TS7006: Parameter '_' implicitly has an 'any' type.
../contracts/evm/ts/generated/DataFeedsCache.ts(1625,38): error TS7006: Parameter 'i' implicitly has an 'any' type.
../contracts/evm/ts/generated/DataFeedsCache.ts(1650,31): error TS7006: Parameter 't' implicitly has an 'any' type.
../contracts/evm/ts/generated/DataFeedsCache.ts(1671,29): error TS7006: Parameter 't' implicitly has an 'any' type.
../contracts/evm/ts/generated/DataFeedsCache.ts(1682,29): error TS7006: Parameter 't' implicitly has an 'any' type.
../contracts/evm/ts/generated/DataFeedsCache.ts(1694,35): error TS7006: Parameter '_' implicitly has an 'any' type.
../contracts/evm/ts/generated/DataFeedsCache.ts(1694,38): error TS7006: Parameter 'i' implicitly has an 'any' type.
../contracts/evm/ts/generated/DataFeedsCache.ts(1719,31): error TS7006: Parameter 't' implicitly has an 'any' type.
../contracts/evm/ts/generated/DataFeedsCache.ts(1740,29): error TS7006: Parameter 't' implicitly has an 'any' type.
../contracts/evm/ts/generated/DataFeedsCache.ts(1751,29): error TS7006: Parameter 't' implicitly has an 'any' type.
../contracts/evm/ts/generated/DataFeedsCache.ts(1763,35): error TS7006: Parameter '_' implicitly has an 'any' type.
../contracts/evm/ts/generated/DataFeedsCache.ts(1763,38): error TS7006: Parameter 'i' implicitly has an 'any' type.
../contracts/evm/ts/generated/DataFeedsCache.ts(1788,31): error TS7006: Parameter 't' implicitly has an 'any' type.
../contracts/evm/ts/generated/DataFeedsCache.ts(1809,29): error TS7006: Parameter 't' implicitly has an 'any' type.
../contracts/evm/ts/generated/DataFeedsCache.ts(1821,29): error TS7006: Parameter 't' implicitly has an 'any' type.
../contracts/evm/ts/generated/DataFeedsCache.ts(1834,35): error TS7006: Parameter '_' implicitly has an 'any' type.
../contracts/evm/ts/generated/DataFeedsCache.ts(1834,38): error TS7006: Parameter 'i' implicitly has an 'any' type.
../contracts/evm/ts/generated/DataFeedsCache.ts(1859,31): error TS7006: Parameter 't' implicitly has an 'any' type.
../contracts/evm/ts/generated/DataFeedsCache.ts(1880,29): error TS7006: Parameter 't' implicitly has an 'any' type.
../contracts/evm/ts/generated/DataFeedsCache.ts(1892,29): error TS7006: Parameter 't' implicitly has an 'any' type.
../contracts/evm/ts/generated/DataFeedsCache.ts(1905,35): error TS7006: Parameter '_' implicitly has an 'any' type.
../contracts/evm/ts/generated/DataFeedsCache.ts(1905,38): error TS7006: Parameter 'i' implicitly has an 'any' type.
../contracts/evm/ts/generated/DataFeedsCache.ts(1930,31): error TS7006: Parameter 't' implicitly has an 'any' type.
../contracts/evm/ts/generated/DataFeedsCache.ts(1951,29): error TS7006: Parameter 't' implicitly has an 'any' type.
../contracts/evm/ts/generated/DataFeedsCache.ts(1963,29): error TS7006: Parameter 't' implicitly has an 'any' type.
../contracts/evm/ts/generated/DataFeedsCache.ts(1976,35): error TS7006: Parameter '_' implicitly has an 'any' type.
../contracts/evm/ts/generated/DataFeedsCache.ts(1976,38): error TS7006: Parameter 'i' implicitly has an 'any' type.
../contracts/evm/ts/generated/DataFeedsCache.ts(2001,31): error TS7006: Parameter 't' implicitly has an 'any' type.
../contracts/evm/ts/generated/DataFeedsCache.ts(2022,29): error TS7006: Parameter 't' implicitly has an 'any' type.
../contracts/evm/ts/generated/DataFeedsCache.ts(2034,29): error TS7006: Parameter 't' implicitly has an 'any' type.
../contracts/evm/ts/generated/DataFeedsCache.ts(2047,35): error TS7006: Parameter '_' implicitly has an 'any' type.
../contracts/evm/ts/generated/DataFeedsCache.ts(2047,38): error TS7006: Parameter 'i' implicitly has an 'any' type.
../contracts/evm/ts/generated/DataFeedsCache.ts(2072,31): error TS7006: Parameter 't' implicitly has an 'any' type.
../contracts/evm/ts/generated/DataFeedsCache.ts(2093,29): error TS7006: Parameter 't' implicitly has an 'any' type.
../contracts/evm/ts/generated/DataFeedsCache.ts(2105,29): error TS7006: Parameter 't' implicitly has an 'any' type.
../contracts/evm/ts/generated/DataFeedsCache.ts(2118,35): error TS7006: Parameter '_' implicitly has an 'any' type.
../contracts/evm/ts/generated/DataFeedsCache.ts(2118,38): error TS7006: Parameter 'i' implicitly has an 'any' type.
../contracts/evm/ts/generated/DataFeedsCache.ts(2143,31): error TS7006: Parameter 't' implicitly has an 'any' type.
../contracts/evm/ts/generated/DataFeedsCache.ts(2164,29): error TS7006: Parameter 't' implicitly has an 'any' type.
../contracts/evm/ts/generated/DataFeedsCache.ts(2175,29): error TS7006: Parameter 't' implicitly has an 'any' type.
../contracts/evm/ts/generated/DataFeedsCache.ts(2187,35): error TS7006: Parameter '_' implicitly has an 'any' type.
../contracts/evm/ts/generated/DataFeedsCache.ts(2187,38): error TS7006: Parameter 'i' implicitly has an 'any' type.
../contracts/evm/ts/generated/DataFeedsCache.ts(2212,31): error TS7006: Parameter 't' implicitly has an 'any' type.
../contracts/evm/ts/generated/DataFeedsCache.ts(2233,29): error TS7006: Parameter 't' implicitly has an 'any' type.
../contracts/evm/ts/generated/DataFeedsCache.ts(2244,29): error TS7006: Parameter 't' implicitly has an 'any' type.
../contracts/evm/ts/generated/DataFeedsCache.ts(2256,35): error TS7006: Parameter '_' implicitly has an 'any' type.
../contracts/evm/ts/generated/DataFeedsCache.ts(2256,38): error TS7006: Parameter 'i' implicitly has an 'any' type.
../contracts/evm/ts/generated/DataFeedsCache.ts(2281,31): error TS7006: Parameter 't' implicitly has an 'any' type.
../contracts/evm/ts/generated/DataFeedsCache.ts(2302,29): error TS7006: Parameter 't' implicitly has an 'any' type.
../contracts/evm/ts/generated/DataFeedsCache.ts(2314,29): error TS7006: Parameter 't' implicitly has an 'any' type.
../contracts/evm/ts/generated/DataFeedsCache.ts(2327,35): error TS7006: Parameter '_' implicitly has an 'any' type.
../contracts/evm/ts/generated/DataFeedsCache.ts(2327,38): error TS7006: Parameter 'i' implicitly has an 'any' type.
../contracts/evm/ts/generated/DataFeedsCache.ts(2352,31): error TS7006: Parameter 't' implicitly has an 'any' type.

Cleaning up...

View full output →

What should I do?

Accidental break: Fix the SDK change so existing templates continue to compile.
Intentional breaking change: Create a branch in cre-templates named compat/CRE-4368-mtls-auth-typescript with the template fixes applied. This job will automatically retest against that branch.

cedric-cordenier requested review from a team as code owners June 5, 2026 12:12

cedric-cordenier changed the base branch from main to capabilities-development June 5, 2026 12:12

cedric-cordenier requested a review from a team as a code owner June 5, 2026 12:12

product-security-plaid-production Bot requested review from DylanTinianov and zeosamaster June 5, 2026 12:12

cedric-cordenier force-pushed the CRE-4368-mtls-auth-typescript branch from f601a50 to e5394f6 Compare June 5, 2026 12:15

russell-stern previously approved these changes Jun 5, 2026

View reviewed changes

CRE-4368: Add mtls auth to typescript SDK

cf41a30

cedric-cordenier dismissed russell-stern’s stale review via cf41a30 June 8, 2026 09:34

cedric-cordenier force-pushed the CRE-4368-mtls-auth-typescript branch from e5394f6 to cf41a30 Compare June 8, 2026 09:34

cedric-cordenier requested a review from russell-stern June 8, 2026 09:37

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

CRE-4368 Add mtls auth to typescript sdk#265

CRE-4368 Add mtls auth to typescript sdk#265
cedric-cordenier wants to merge 1 commit into
capabilities-developmentfrom
CRE-4368-mtls-auth-typescript

cedric-cordenier commented Jun 5, 2026

Uh oh!

github-actions Bot commented Jun 5, 2026

Uh oh!

github-actions Bot commented Jun 5, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Conversation

cedric-cordenier commented Jun 5, 2026

Uh oh!

github-actions Bot commented Jun 5, 2026

Uh oh!

github-actions Bot commented Jun 5, 2026

⚠️ Template Compatibility Failures

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants