Skip to content

Add new forex-continuous endpoint for NCFX 24/7 forex#4635

Open
mohamed-mehany wants to merge 2 commits intomainfrom
ncfx-forex-continuous
Open

Add new forex-continuous endpoint for NCFX 24/7 forex#4635
mohamed-mehany wants to merge 2 commits intomainfrom
ncfx-forex-continuous

Conversation

@mohamed-mehany
Copy link
Collaborator

@mohamed-mehany mohamed-mehany commented Feb 13, 2026

Closes #OPDATA-5905

Description

Add new forex-continuous endpoint for NCFX 24/7 forex WebSocket feed

Changes

  • Add new forex-continuous endpoint for NCFX 24/7 forex WebSocket feed
  • Return LWBA format response (bid, mid, ask)
  • Add FOREX_CONTINUOUS_WS_API_ENDPOINT config variable
  • Add integration tests and fixtures

Steps to Test

  1. Integration tests
  2. Local server curl tests

Quality Assurance

  • If a new adapter was made, or an existing one was modified so that its environment variables have changed, update the relevant infra-k8s configuration file.
  • If a new adapter was made, or an existing one was modified so that its environment variables have changed, update the relevant adapter-secrets configuration file.
  • If a new adapter was made, or a new endpoint was added, update the test-payload.json file with relevant requests.
  • The branch naming follows git flow (feature/x, chore/x, release/x, hotfix/x, fix/x) or is created from Jira.
  • This is related to a maximum of one Jira story or GitHub issue.
  • Types are safe (avoid TypeScript/TSLint features like any and disable, instead use more specific types).
  • All code changes have 100% unit and integration test coverage. If testing is not applicable or too difficult to justify doing, the reasoning should be documented explicitly in the PR.

- Add new forex-continuous endpoint for NCFX 24/7 forex WebSocket feed
- Connect to wss://cryptofeed.ws.newchangefx.com/fiat_v1
- Use '-' pair separator (e.g., ARS-USD) instead of '/'
- Return LWBA format response (bid, mid, ask)
- Add FOREX_CONTINUOUS_WS_API_ENDPOINT config variable
- Add integration tests and fixtures
@changeset-bot
Copy link

changeset-bot bot commented Feb 13, 2026

🦋 Changeset detected

Latest commit: 18043b6

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 7 packages
Name Type
@chainlink/ncfx-adapter Minor
@chainlink/token-allocation-adapter Patch
@chainlink/bsol-price-adapter Patch
@chainlink/crypto-volatility-index-adapter Patch
@chainlink/savax-price-adapter Patch
@chainlink/set-token-index-adapter Patch
@chainlink/xsushi-price-adapter Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@mohamed-mehany mohamed-mehany changed the title Ncfx forex continuous Add new forex-continuous endpoint for NCFX 24/7 forex Feb 13, 2026
@mohamed-mehany mohamed-mehany marked this pull request as ready for review February 13, 2026 22:11

export const forexContinuousEndpoint = new AdapterEndpoint({
name: 'forex-continuous',
aliases: ['forex_continuous', 'forexcontinuous'],
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why do we need these?

!priceMessage.bid ||
!priceMessage.ask
) {
logger.debug('WS message does not contain valid data, skipping')
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should be warning

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants