Repository navigation
docs(aso): clarify list_builds limit=200 is page size, not a cap - #24
Merged
Merged
Conversation
setoelkahfi
added this pull request to stack #27
October 11, 2026 18:49
setoelkahfi
added a commit
that referenced
this pull request
Oct 11, 2026
…28) Update the sitiai and klepon release-session plans to reflect what gh stack #27 landed (#24 docs/list-builds-pagination -> #25 feat/signing-doctor -> #26 feat/apps-await-processing): - sitiai: add a 2025-10-11 progress callout; mark findings #2 (signing doctor, PR #25), #5 (await-processing, PR #26) and #6 (list_builds pagination doc, PR #24) as shipped; detail the await-processing CLI surface; note the upload.rs cluster (#3 + #1, #4 folded) is next. - klepon: cross-link the two findings that built on its builds API (#6 pagination doc, #5 await-processing on BuildsApi::list_builds). Co-authored-by: siGit Code v1.6.7-acp <noreply@sigit.si>
setoelkahfi
force-pushed
the
docs/list-builds-pagination
branch
from
October 11, 2026 19:15
b38aa61 to
4c775f1
Compare
paydii
marked this pull request as ready for review
October 11, 2026 19:15
![sigit-code-review[bot]](https://avatars.githubusercontent.com/in/3492899?s=60&v=4){kind=small}
There was a problem hiding this comment.
The change clarifies the documentation for the list_builds method in the BuildsApi trait, specifying that the limit=200 parameter is a page size limit imposed by Apple, not a total cap on the number of builds returned. It explains that the client follows pagination links to retrieve all builds, so the returned vector can contain more than 200 builds. This prevents misunderstanding that the vector length is capped at 200.
Automated review by siGit Code Review · commit 4c775f1 · see the review dashboard
paydii
approved these changes
Oct 11, 2026
The `limit=200` on the builds collection reads like a ceiling, but `list_all` follows Apple's `links.next` cursor until the collection is exhausted. Spell out that 200 is the largest page ASC allows (fewer round-trips), not the number of builds returned, so callers don't treat the vector length as "the 200 most recent builds." Co-Authored-By: siGit Code v1.6.7-acp <noreply@sigit.si>
setoelkahfi
force-pushed
the
docs/list-builds-pagination
branch
from
October 11, 2026 22:01
4c775f1 to
cd33a06
Compare
setoelkahfi
added a commit
that referenced
this pull request
Oct 13, 2026
…ss notes (#38) The three release-session plan files in .agents/plans/ were mostly stale: every shipped code finding from them is already on development. Close them out by checking items against the current tree, and move the few still-useful notes into AGENTS.md so future sessions don't have to dig through three plan files to find them. Plan-by-plan: * klepon (token-source + builds API): all scope items landed. Unit tests for token.rs (CountingSource in crates/core/src/client.rs, StaticToken / boxed source in crates/core/src/token.rs) cover the 'Client::new over a custom TokenSource' gap; the MCP list_builds tool already constructs BuildFilter from the request. The separate 'stale AuthKey_<id>.p8' finding is now documented in AGENTS.md under 'App Store Connect key location'. * sitiai (upload + signing-identity hardening): all six findings landed. Pre-flight altool --validate-app, body-aware success, .app-vs-.pkg distinction shipped in crates/frontend/src/upload.rs; asc signing doctor (PR #25); asc apps await-processing (PR #26); list_builds pagination doc (PR #24). The credential-blocked live ASC smoke test is the one remaining item and is shared with the klepon plan. * splitfire (TestFlight release session): testflight CLI surface shipped; the 'rebuild asc first' warning and the finish-the-release recipe are now in AGENTS.md under 'Verify before relying on a freshly built asc' and 'Finish-the-release recipe (TestFlight)'. AGENTS.md (symlinked from the repo root as both AGENTS.md and CLAUDE.md) gains three short sections instead of one big paragraph, so a reader scanning the doc index can find each rule directly. Verified locally: cargo fmt --check, cargo clippy -D warnings, cargo test, RUSTDOCFLAGS=-D warnings cargo doc --workspace, and the lower-crate solo builds (core / aso / signing) all clean. Co-authored-by: OndeCode v1.0.3-acp <noreply@ondeinference.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
limit=200on the builds collection reads like a ceiling, butlist_allfollows Apple'slinks.nextcursor until the collection isexhausted. Spell out that 200 is the largest page ASC allows (fewer
round-trips), not the number of builds returned, so callers don't treat
the vector length as "the 200 most recent builds."
Co-Authored-By: siGit Code v1.6.7-acp noreply@sigit.si
Stack created with GitHub Stacks CLI • Give Feedback 💬