Repository navigation
fix(aso): omit null attributes in beta app review submit body - #31
Merged
Merged
Conversation
Apple's betaAppReviewSubmissions endpoint 422s (ENTITY_UNPROCESSABLE) when data.attributes is present but null. The create body built its POST with the generic CreateBody/CreateData whose attributes: () serialized to "attributes": null. Introduce dedicated local CreateBody/CreateData/CreateRelationships carrying only the build relationship (no attributes field), mirroring the review_submission.rs pattern. Replace the misleading test that asserted the buggy null with one asserting attributes is absent. Co-Authored-By: siGit Code v1.6.7-acp <noreply@sigit.si>
![sigit-code-review[bot]](https://avatars.githubusercontent.com/in/3492899?s=60&v=4){kind=small}
There was a problem hiding this comment.
Fix beta app review submission POST body to omit the attributes field instead of sending it as null, which causes a 422 error from Apple's API. Introduced local CreateBody/CreateData/CreateRelationships structs without attributes to mirror the expected request shape. Updated the test to assert that attributes is omitted rather than null, and verified correct serialization of the build relationship.
Automated review by siGit Code Review · commit 0546434 · see the review dashboard
paydii
approved these changes
Oct 11, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
submit_build_for_beta_reviewbuilt its POST body withattributes: (), which serializes to"attributes": null. Apple'sbetaAppReviewSubmissionsendpoint 422s (ENTITY_UNPROCESSABLE) on a nullattributes— the field must be omitted entirely.Fix
CreateBody/CreateDataimports; added localCreateBody/CreateData/CreateRelationshipsthat carry only thebuildrelationship and noattributesfield, mirroringreview_submission.rs.create_body_attributes_unit_serializestest withcreate_body_omits_attributes(assertsattributesis absent, and that the type + build id are correct).Verification
cargo fmt --check,clippy --workspace --all-targets -D warnings,cargo test -p smbcloud-ascapi-aso— all green.ecb4ba9e-6be1-4dc3-9a6e-0385b9b8b243(KaroKowe Jam20261011.2035);betaReviewStateis nowWAITING_FOR_REVIEWwith a realsubmittedDate.