Implement new event streams API#1035
Merged
sugmanue merged 11 commits intosmithy-lang:mainfrom Feb 27, 2026
Merged
Conversation
core/src/main/java/software/amazon/smithy/java/core/serde/event/DefaultEventStreamReader.java
Outdated
Show resolved
Hide resolved
| try { | ||
| LOGGER.debug("Writing event {} (latch count: {})", | ||
| event.getClass().getSimpleName(), | ||
| readyLatch.getCount()); |
Contributor
There was a problem hiding this comment.
getCount incurs a volatile read of readyLatch's backing state, please only call this if debug logs are enabled
core/src/main/java/software/amazon/smithy/java/core/serde/event/EventPipeStream.java
Outdated
Show resolved
Hide resolved
core/src/main/java/software/amazon/smithy/java/core/serde/event/DefaultEventStreamWriter.java
Outdated
Show resolved
Hide resolved
core/src/main/java/software/amazon/smithy/java/core/serde/event/DefaultEventStreamWriter.java
Outdated
Show resolved
Hide resolved
core/src/main/java/software/amazon/smithy/java/core/serde/event/DefaultEventStreamWriter.java
Show resolved
Hide resolved
core/src/main/java/software/amazon/smithy/java/core/serde/event/DefaultEventStreamWriter.java
Outdated
Show resolved
Hide resolved
core/src/main/java/software/amazon/smithy/java/core/serde/event/DefaultEventStreamWriter.java
Show resolved
Hide resolved
core/src/main/java/software/amazon/smithy/java/core/serde/event/EventPipeStream.java
Outdated
Show resolved
Hide resolved
mtdowling
requested changes
Feb 25, 2026
core/src/main/java/software/amazon/smithy/java/core/serde/event/DefaultEventStreamReader.java
Outdated
Show resolved
Hide resolved
core/src/main/java/software/amazon/smithy/java/core/serde/event/DefaultEventStreamReader.java
Outdated
Show resolved
Hide resolved
http/http-binding/src/main/java/software/amazon/smithy/java/http/binding/RequestSerializer.java
Outdated
Show resolved
Hide resolved
| if (eventStream != null && operation instanceof InputEventStreamingApiOperation<?, ?, ?>) { | ||
| builder.body(EventStreamFrameEncodingProcessor.create(eventStream, eventStreamEncodingFactory)); | ||
| ProtocolEventStreamWriter<SerializableStruct, SerializableStruct, Frame<?>> writer = | ||
| ProtocolEventStreamWriter.toInternal(eventStream); |
Member
There was a problem hiding this comment.
toInternal seems like a leftover from the previous naming. Just call it of: ProtocolEventStreamWriter.of
core/src/main/java/software/amazon/smithy/java/core/serde/event/DefaultEventStreamWriter.java
Outdated
Show resolved
Hide resolved
core/src/main/java/software/amazon/smithy/java/core/serde/event/EventStream.java
Outdated
Show resolved
Hide resolved
core/src/main/java/software/amazon/smithy/java/core/serde/event/ProtocolEventStreamWriter.java
Outdated
Show resolved
Hide resolved
core/src/main/java/software/amazon/smithy/java/core/serde/event/ProtocolEventStreamWriter.java
Outdated
Show resolved
Hide resolved
core/src/main/java/software/amazon/smithy/java/core/serde/event/EventPipeStream.java
Outdated
Show resolved
Hide resolved
core/src/main/java/software/amazon/smithy/java/core/serde/event/EventPipeStream.java
Show resolved
Hide resolved
Co-authored-by: Michael Dowling <michael@mtdowling.com>
mtdowling
reviewed
Feb 26, 2026
| int read = inputStream.read(buffer); | ||
|
|
||
| if (read == -1) { | ||
| var error = new IOException("Unexpected end of stream while reading initial event"); |
Member
There was a problem hiding this comment.
This is going to catch the IOException and call closeWithError twice
Contributor
Author
There was a problem hiding this comment.
duh, let me just throw the exception as originally suggested 🤦
| /** | ||
| * Default timeout to block waiting to write. | ||
| */ | ||
| private static final int WRITE_TIMEOUT_MILLIS = 1500; |
Member
There was a problem hiding this comment.
Main concern here is -- is this universally enough time? I am not positive 1.5 seconds is enough. Not sure if this has to be configurable yet, but maybe this should be more like 10 seconds or something like that to account for long setup, but still give some mitigation against hanging forever.
Contributor
Author
There was a problem hiding this comment.
Yea, I don't think there's a way to finding that out, 1.5 seemed like a good one but we can use 10 as well. Let me change it.
mtdowling
approved these changes
Feb 26, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
Description of changes:
Implements a new event streams API that's VT friendly by blocking when the caller reads and writes events.
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.