refactor: Drive JSON/CBOR serde off the data with a load-time wire-name map - #351
Draft
jterapin wants to merge 3 commits into
Draft
refactor: Drive JSON/CBOR serde off the data with a load-time wire-name map#351jterapin wants to merge 3 commits into
jterapin wants to merge 3 commits into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Context
V4 walks every declared schema member on each request and response and resolves each wire name inline. This restores the load-time reverse map V3 had and drives JSON/CBOR (de)serialization off the data instead of the full member list.
What changed
StructureShapebuilds@members_by_wire_nameatadd_member, keyed by each member'slocation_nameandjsonName(when different); wire-name collisions raise at load.structurebuild/parse now iterate the input values / payload keys and resolve members through the map.Testing
--
Written with AI assistance and reviewed by jterapin.
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.