Skip to content

fix: parse list-valued plugin settings with nargs - #102

Open
tedil wants to merge 1 commit into
mainfrom
fix/list-settings-nargs
Open

tedil wants to merge 1 commit into
mainfrom
fix/list-settings-nargs

Conversation

@tedil

@tedil tedil commented Oct 23, 2026

Copy link
Copy Markdown

Settings typed List[X] or Optional[List[X]] with nargs failed when read, because the field type was called on the value (typing.List[str](...)). Values are now converted item by item with the element type, which also works for lists coming from a profile or config.

Fixes #100.

I used AI assistance for code generation, tests, and research.

@coderabbitai

coderabbitai Bot commented Oct 23, 2026 •

Copy link
Copy Markdown

Important

  • 🔍 Trigger review

This repository does not receive automatic reviews because it has fewer than 10 stars.

⚙️ Run configuration
  • Source mode: Auto
  • Repository: Unavailable
  • Branch: Unavailable
  • File: No configuration file from this repository applied
  • Commit: Unavailable
  • Layers: Organization UI
  • Review profile: CHILL
  • Plan: Advanced
  • Run ID: f1b76930-8880-4ab1-b028-dc4ab16850db
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@tedil
tedil marked this pull request as ready for review October 23, 2026 11:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

plugin settings with list values cannot be parsed

1 participant