Conversation
agatakrajewska
force-pushed
the
feat/fp
branch
2 times, most recently
from
November 22, 2021 16:02
2f78cbc to
71f7aa5
Compare
agatakrajewska
marked this pull request as ready for review
November 22, 2021 16:03
miiila
reviewed
Nov 23, 2021
| static std::string last_stack = ""; | ||
|
|
||
| /// this isn't shared, it's only used from the node thread | ||
| v8::Local<v8::Function> callback; |
There was a problem hiding this comment.
suggestion: I believe we can delete this and 33
agatakrajewska
force-pushed
the
feat/fp
branch
from
November 23, 2021 15:48
71f7aa5 to
0fad127
Compare
Author
|
Looks good to me. I can't approve it, as I raised it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We're exposing a new
subscribeToEventsmember. Example usage in the application code: