chore(deps): ws@8.21.0 (fixes DoS vulnerability)#5502
Merged
Conversation
hashim2266
approved these changes
May 25, 2026
Member
|
@AviVahl thanks for your pull request. However, we have had breaking changes from dependencies affecting users in the past, hence the current |
Contributor
Author
|
@darrachequesne done, even though I think the approach of locking it partially has its own downsides. |
AviVahl
force-pushed
the
avi/upgrade-ws-again
branch
from
4c3e4c4 to
f99a068
Compare
Contributor
Author
|
Alright, I've rebased so that all |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
change ws requests to carets, as package respects semverhttps://github.com/websockets/ws/releases/tag/8.21.0
@darrachequesne since this is the third time I'm updating this one, I've also changed it to carets so that any future vulnerability fixes are automatically targeted.The kind of change this PR does introduce