Prepare and validate release branches before publication - #5
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Release branches need to contain the version bump and every generated release change before review. The existing branch task treats the version task's result hash as a filename, creates the branch after generation, and stages only the version file.
This fixes
gem:release:branch:patch/minor/majorto require a clean branch checkout, createreleases/vVERSIONbefore generation, run the existing hooks, and commit all resulting changes. Generated private keys and package output are rejected before staging; failed hook output remains available for inspection.gem:release:validate base=... candidate=...independently regenerates a release from the base and proposed version, then compares the complete source tree. Rebases pass when the generated content still matches; stale notes and unexpected additions or deletions fail with a diff. After merge, callers use the merged commit's first parent as the base. Validation supports stable patch/minor/major versions and requires repeatable hooks.Worktree operations run ordinary Bake tasks in fresh Ruby processes, avoiding cached version constants and building from committed source.
gem:buildaccepts a signing key path or true/false, and local publication pushes only the intended release tag. The helper requires the caller to run from the gem's root directory and never changes the process's working directory.Tests use Sus 0.38's
TemporaryDirectoryContextandIsolatedRubyContext, with explicitchdir: root. The guide, generated agent context, andUnreleasednotes document the behavior. This provides the provider-independent foundation for the separatebake-gem-githubintegration.Validation:
origin/mainare covered. Overall line coverage is 90.65% (320/353); remaining gaps are in unchanged code. The existing global 100% CI coverage gate remains unchanged.