Preserve animated slide state during view transitions - #49
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When advancing between animated slides on
/display, disposing the outgoing slide reverts its Anime.js styles before the browser captures the fade snapshot. This briefly exposes the complete, unanimated diagram before the next slide's animation begins. The presenter preview skips view transitions, so it does not show the flash.Transfer ownership of outgoing slide resources to the replacement rendering, then dispose them inside the view-transition update callback, after capture and before updating the DOM. Superseded renderings still cancel pending updates and transitions immediately. Apply the same handoff to recorded playback while stopping narration immediately.
Validation:
npm test: all 31 tests pass, including regressions using real Anime.js scopes for outgoing snapshot state, synchronous replacement, hidden/unsupported transitions, rapid navigation before and after a pending update, and disposal before replacement.bundle exec bake web:packages:check: passes; generated browser assets are updated.git diff --check: pass.Browser visual verification is still pending; the regression tests control the view-transition snapshot/update boundary.