Repository navigation
Scale component spacing and refine table styling - #42
Merged
Merged
Conversation
Signed-off-by: Samuel Williams <samuel.williams@shopify.com>
Signed-off-by: Samuel Williams <samuel.williams@shopify.com>
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Component padding currently uses the root font size even when its text is smaller or larger. Use
emfor table-cell, inline-code, badge, and navigation-link spacing so each scales with its own text. Compact navigation and badges get spacing proportional to their smaller fonts.Set table-cell padding to
0.1em 0.4emfor a compact layout. Shade every second column, including its header, with a 2% tint of the theme's text colour. The translucent tint works in light and dark modes and allows row hover highlighting to remain visible.Keep breadcrumb offsets matched to link padding, and use consistent
empadding and summary offsets for disclosures so opening adetailselement does not shift its summary at a different font size. Related corner radii follow the local font as well. Shared page widths, sidebar widths, margins, and layout gaps remain inrem.Validation:
git diff --checkpasses for the CSS changes.Local Ruby setup was blocked by incompatible native extensions in the installed gem environment; Ruby checks are left to CI.