Repository navigation
[SofaImGui] Construct the DataWidgetFactory map on first use - #305
Merged
Merged
Conversation
factoryMap was an inline static data member, filled by the dw_* globals
of ImGuiDataWidget.cpp during static initialization. With clang-cl, the
initializer of an inline variable is emitted in a separately ordered CRT
section, so the dw_* initializers could run before the map was
constructed, crashing with an access violation when loading
SofaImGui.dll ("DLL initialization routine failed").
The map is now a function-local static, constructed on first use.
fredroy
force-pushed
the
fix_msvc_cl_fixes
branch
from
October 29, 2026 00:23
c3f42e9 to
2becd7c
Compare
alxbilger
approved these changes
Oct 29, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fixing some shenanigans to allow clang-msvc to compile sofaimgui
finding this issue without ai would have been .... complicated 💀