feat: Lint rule for invalid assignment#2235
Draft
aleksanderkatan wants to merge 13 commits intofeat/lint-unwrapped-pojosfrom
Draft
feat: Lint rule for invalid assignment#2235aleksanderkatan wants to merge 13 commits intofeat/lint-unwrapped-pojosfrom
aleksanderkatan wants to merge 13 commits intofeat/lint-unwrapped-pojosfrom
Conversation
added 13 commits
February 27, 2026 17:21
|
pkg.pr.new packages benchmark commit |
📊 Bundle Size Comparison
👀 Notable resultsStatic test results:No major changes. Dynamic test results:No major changes. 📋 All resultsClick to reveal the results table (344 entries).
If you wish to run a comparison for other, slower bundlers, run the 'Tree-shake test' from the GitHub Actions menu. |
There was a problem hiding this comment.
Pull request overview
Adds a new TypeGPU ESLint rule to detect assignments inside 'use gpu' functions that won’t translate to valid WGSL (parameter mutation and writes to JS variables captured from outer scopes), and updates existing tests/code to comply with the new linting behavior.
Changes:
- Introduces
typegpu/invalid-assignmentrule with dedicated rule-tester coverage. - Extends directive tracking to expose the enclosing TypeGPU function node (instead of a boolean).
- Updates TypeGPU tests to either use
.$ford.refmutations or disable the rule where mutation is intentional for test scenarios.
Reviewed changes
Copilot reviewed 7 out of 7 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| packages/typegpu/tests/tgsl/argumentOrigin.test.ts | Disables the new lint rule for intentional mutation cases in tests. |
| packages/typegpu/tests/ref.test.ts | Updates d.ref mutation syntax to use .$ accessors. |
| packages/eslint-plugin/tests/invalidAssignment.test.ts | Adds comprehensive tests for the new rule across parameter and outer-scope assignments. |
| packages/eslint-plugin/src/rules/unwrappedPojos.ts | Adapts to the updated directive tracking API. |
| packages/eslint-plugin/src/rules/invalidAssignment.ts | Implements the new invalid-assignment rule. |
| packages/eslint-plugin/src/enhancers/directiveTracking.ts | Changes directive tracking to return the enclosing TypeGPU function node when applicable. |
| packages/eslint-plugin/src/configs.ts | Registers the new rule and enables it in recommended/all configs. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.