Open
Conversation
|
pkg.pr.new packages benchmark commit |
📊 Bundle Size Comparison
👀 Notable resultsStatic test results:No major changes. Dynamic test results:No major changes. 📋 All resultsClick to reveal the results table (344 entries).
If you wish to run a comparison for other, slower bundlers, run the 'Tree-shake test' from the GitHub Actions menu. |
There was a problem hiding this comment.
Pull request overview
Fixes vector slider controls in the docs UI by making vector slider params/components work with typegpu vector types.
Changes:
- Strongly-typed
VectorSliderControlParamto used.v2f | d.v3f | d.v4finstead ofnumber[]. - Updated
VectorSlider/ControlPanelvector slider row to handletypegpuvectors. - Tweaked default Phong reflection control values and updated workspace VS Code settings.
Reviewed changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated 6 comments.
Show a summary per file
| File | Description |
|---|---|
| apps/typegpu-docs/src/utils/examples/exampleControlAtom.ts | Introduces generic vector slider control param types and unions for v2/v3/v4. |
| apps/typegpu-docs/src/examples/rendering/phong-reflection/params.ts | Updates default control values for the phong reflection example. |
| apps/typegpu-docs/src/components/design/VectorSlider.tsx | Updates vector slider component to clone/update typegpu vectors instead of array slicing. |
| apps/typegpu-docs/src/components/ControlPanel.tsx | Updates vector slider row state and handler typing for typegpu vectors. |
| .vscode/settings.json | Disables Deno in the workspace settings. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
You can also share your feedback on Copilot code review. Take the survey.
aleksanderkatan
force-pushed
the
fix/vector-slider-controls
branch
from
1a6d413 to
0fde771
Compare
reczkok
approved these changes
Mar 4, 2026
iwoplaza
approved these changes
Mar 5, 2026
| @@ -1,4 +1,5 @@ | |||
| { | |||
| "deno.enable": false, | |||
Collaborator
There was a problem hiding this comment.
Let's remove it, since we got rid of deno,json files
Suggested change
| "deno.enable": false, |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #2244
Changes:
I tried to use
vecBasehere but it also wasn't clean, since it cannot be index-accessed, and is not assignable to any vec (thus cannot be easily used in vector constructors)