chore (@typegpu/cli): minor improvements#2583
Draft
cieplypolar wants to merge 3 commits into
Draft
Conversation
|
pkg.pr.new packages benchmark commit |
📊 Bundle Size Comparison
👀 Notable resultsStatic test results:No major changes. Dynamic test results:No major changes. 📋 All resultsClick to reveal the results table (355 entries).
If you wish to run a comparison for other, slower bundlers, run the 'Tree-shake test' from the GitHub Actions menu. |
Resolution Time Benchmark---
config:
themeVariables:
xyChart:
plotColorPalette: "#E63946, #3B82F6, #059669"
---
xychart
title "Random Branching (🔴 PR | 🔵 main | 🟢 release)"
x-axis "max depth" [1, 2, 3, 4, 5, 6, 7, 8]
y-axis "time (ms)"
line [0.95, 1.96, 4.14, 6.80, 7.39, 10.80, 21.68, 21.42]
line [0.95, 1.83, 4.16, 6.75, 7.70, 11.62, 22.52, 22.45]
line [0.90, 1.87, 3.93, 7.11, 7.88, 10.81, 20.97, 20.92]
---
config:
themeVariables:
xyChart:
plotColorPalette: "#E63946, #3B82F6, #059669"
---
xychart
title "Linear Recursion (🔴 PR | 🔵 main | 🟢 release)"
x-axis "max depth" [1, 2, 3, 4, 5, 6, 7, 8]
y-axis "time (ms)"
line [0.34, 0.54, 0.66, 0.82, 1.10, 1.20, 1.50, 1.62]
line [0.31, 0.57, 0.71, 0.91, 1.18, 1.27, 1.49, 1.61]
line [0.35, 0.54, 0.74, 0.82, 1.07, 1.18, 1.39, 1.58]
---
config:
themeVariables:
xyChart:
plotColorPalette: "#E63946, #3B82F6, #059669"
---
xychart
title "Full Tree (🔴 PR | 🔵 main | 🟢 release)"
x-axis "max depth" [1, 2, 3, 4, 5, 6, 7, 8]
y-axis "time (ms)"
line [0.83, 2.15, 4.20, 6.63, 12.23, 25.83, 55.28, 112.68]
line [0.88, 2.22, 4.21, 7.25, 12.68, 25.86, 53.93, 113.23]
line [0.83, 2.14, 4.64, 7.12, 12.96, 25.64, 55.17, 112.52]
|
There was a problem hiding this comment.
Pull request overview
This PR updates @typegpu/cli housekeeping and template scaffolding to align with newer dependencies and remove an extra filesystem dependency.
Changes:
- Bump
@clack/promptsand update lockfile accordingly. - Remove
rimrafusage by switching directory cleanup tofs.rmSync. - Ignore
.agents/**in templateoxlintconfigs and addapp.jsonhandling during scaffolding.
Reviewed changes
Copilot reviewed 7 out of 8 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| pnpm-lock.yaml | Updates lockfile for @clack/prompts bump and removes rimraf entries. |
| packages/typegpu-cli/package.json | Bumps @clack/prompts and removes rimraf dependency. |
| packages/typegpu-cli/src/utils/types.ts | Adds AppJsonSchema for validating template app.json. |
| packages/typegpu-cli/src/utils/files.ts | Replaces rimraf with fs.rmSync, skips copying app.json, and writes a customized app.json when present. |
| packages/typegpu-cli/templates/template-vite-simple/oxlint.config.ts | Ignores .agents/** for oxlint in the template. |
| packages/typegpu-cli/templates/template-vite-react/oxlint.config.ts | Ignores .agents/** for oxlint in the template. |
| packages/typegpu-cli/templates/template-vite-complex/oxlint.config.ts | Ignores .agents/** for oxlint in the template. |
| packages/typegpu-cli/templates/template-expo-simple/oxlint.config.ts | Ignores .agents/** for oxlint in the template. |
Files not reviewed (1)
- pnpm-lock.yaml: Language not supported
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes:
nameandsluginapp.jsontopackageName