feat(ios): add link rendering, theme, and onLinkPress#563
Open
graszka22 wants to merge 1 commit into
Open
Conversation
Render links with tint color and underline, add Link theme element, and wire UITextViewDelegate for custom link tap handling via .onLinkPress. Co-authored-by: Cursor <cursoragent@cursor.com>
|
Hi @graszka22, Thanks for putting this PR together! I have a quick question if you have a moment. I'm working on a React Native (Expo) app where I'd like to replace markdown links with a completely custom UI—for example, a rounded chip containing the website's favicon and label, similar to how ChatGPT or Gemini renders citations. I'd like to do this during rendering rather than by pre-processing the markdown with regex, since that's fragile and can cause issues with RTL text and other markdown edge cases. Do you have any suggestions for the best way to achieve this? Or is your team planning to support something like this in the future? Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Render links with tint color and underline, add Link theme element, and wire UITextViewDelegate for custom link tap handling via .onLinkPress.
What/Why?
Testing
PR Checklist