refactor(input): extract EditPipeline from input views (iOS & Android)#589
Merged
Conversation
Move the per-keystroke text-change processing sequence (store adjustment, orphan pruning, block continuation, pending styles, formatting, and detection) into a dedicated EditPipeline class on each platform. The views now build an immutable EditContext and delegate to the pipeline, keeping only UI-specific post-processing (formatting on iOS, scroll/cursor sync, event emission on Android stays in the pipeline). Pure structural extraction — no behavioral changes. Co-authored-by: Cursor <cursoragent@cursor.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What/Why?
Move the per-keystroke text-change processing sequence (store adjustment, orphan pruning, block continuation, pending styles, formatting, and detection) into a dedicated EditPipeline class on each platform. The views now build an immutable EditContext and delegate to the pipeline, keeping only UI-specific post-processing (formatting on iOS, scroll/cursor sync, event emission on Android stays in the pipeline).
Pure structural extraction - no behavioral changes.
Testing
PR Checklist