refactor(input): extract BlockEditCoordinator (iOS & Android)#591
Merged
Conversation
Phase 3 of the input architecture refactor: moves block-editing operations (toggle block type, toggle list, change depth) and block query helpers (blockAtPosition, listBlockAtPosition, headingLevel) into a dedicated BlockEditCoordinator on each platform. The view retains the keyboard interception (handleListKey), UI effects (formatting, typing attributes, empty bullet marker, anchor sync, cursor sizing), and event emission. The coordinator owns pure block-store mutations and query logic, accepting text + selection as parameters and returning results the view acts on. ~250 lines removed from the two views, ~350 lines in two new files. Co-authored-by: Cursor <cursoragent@cursor.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What/Why?
Phase 3 of the input architecture refactor: moves block-editing operations (toggle block type, toggle list, change depth) and block query helpers (blockAtPosition, listBlockAtPosition, headingLevel) into a dedicated BlockEditCoordinator on each platform.
The view retains the keyboard interception (handleListKey), UI effects (formatting, typing attributes, empty bullet marker, anchor sync, cursor sizing), and event emission. The coordinator owns pure block-store mutations and query logic, accepting text + selection as parameters and returning results the view acts on.
Testing
PR Checklist