[Android] Properly handle `requestDisallowInterceptTouchEvent` for v3 by j-piasecki · Pull Request #4367 · software-mansion/react-native-gesture-handler

j-piasecki · 2026-07-30T13:21:37Z

Description

On Android, when a native view calls requestDisallowInterceptTouchEvent (e.g. a pager starting a swipe), RNGestureHandlerRootView reacted by cancelling all handlers registered on the root. react-native-pager-view calls it eagerly on touch down, so any v3 gesture rendered inside a pager (e.g. inside material top tabs) was cancelled before it could activate — a long press nested in top tabs never activated at all.

This PR makes the cancellation targeted:

The root view now cancels only legacy handlers (v1/v2 action types) via the new GestureHandlerOrchestrator.cancelAllLegacyHandlers, instead of the old trick of activating the internal RootViewGestureHandler. The root handler is now attached with ACTION_TYPE_NONE so it's excluded from that sweep (and no longer sends dead events to JS).
v3 handlers are cancelled by new requestDisallowInterceptTouchEvent overrides on RNGestureHandlerDetectorView and ButtonViewGroup. Since the request only bubbles upward from the requesting view, only handlers attached to its ancestors are cancelled — handlers below the requester (like the long press under the pager) keep working.
Cancellation is skipped while the orchestrator is delivering events (isHandlingTouch), mirroring the existing passingTouch guard, so disallow requests caused by RNGH's own event delivery don't cancel gestures.
findGestureHandlerRootView now returns the nearest enabled root view so the checks above consult the orchestrator that actually manages the subtree.

Test plan

Tested on reproducer from #2383

Screen.Recording.2026-07-31.at.11.38.38.mov

Copilot

Pull request overview

This PR adjusts Android’s requestDisallowInterceptTouchEvent handling to avoid canceling v3 gestures too broadly (notably inside pagers), by making cancellation more targeted across root/orchestrator and v3 detector/button views.

Changes:

Add GestureHandlerOrchestrator.cancelAllLegacyHandlers() and use it from the root helper instead of triggering cancellation via the internal root handler.
Override requestDisallowInterceptTouchEvent in v3 host detector and button view to cancel only relevant handlers (and skip cancellation while the orchestrator is handling touch).
Update root view lookup to prefer the nearest enabled RNGestureHandlerRootView and expose the orchestrator via the root view/root helper.

Reviewed changes

Copilot reviewed 5 out of 5 changed files in this pull request and generated 3 comments.

Show a summary per file

File	Description
packages/react-native-gesture-handler/android/src/main/java/com/swmansion/gesturehandler/react/RNGestureHandlerRootView.kt	Exposes orchestrator and returns nearest enabled GH root view when searching ancestors.
packages/react-native-gesture-handler/android/src/main/java/com/swmansion/gesturehandler/react/RNGestureHandlerRootHelper.kt	Switches root-level cancellation to `cancelAllLegacyHandlers` and attaches root handler with `ACTION_TYPE_NONE`.
packages/react-native-gesture-handler/android/src/main/java/com/swmansion/gesturehandler/react/RNGestureHandlerDetectorView.kt	Adds `requestDisallowInterceptTouchEvent` override to cancel v3 handlers attached via the host detector.
packages/react-native-gesture-handler/android/src/main/java/com/swmansion/gesturehandler/react/RNGestureHandlerButtonViewManager.kt	Adds `requestDisallowInterceptTouchEvent` override to cancel the button’s managed v3 handler.
packages/react-native-gesture-handler/android/src/main/java/com/swmansion/gesturehandler/core/GestureHandlerOrchestrator.kt	Introduces `cancelAllLegacyHandlers()` to selectively cancel v1/v2 action types.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

coderabbitai · 2026-08-03T06:30:47Z

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

Configuration used: Repository UI

Review profile: CHILL

Plan: Pro Plus

Run ID: beec65eb-e680-492b-8610-5310e0a4cb44

📥 Commits

Reviewing files that changed from the base of the PR and between dd2e6bc and dc49bcc.

📒 Files selected for processing (5)

packages/react-native-gesture-handler/android/src/main/java/com/swmansion/gesturehandler/core/GestureHandlerOrchestrator.kt
packages/react-native-gesture-handler/android/src/main/java/com/swmansion/gesturehandler/react/RNGestureHandlerButtonViewManager.kt
packages/react-native-gesture-handler/android/src/main/java/com/swmansion/gesturehandler/react/RNGestureHandlerDetectorView.kt
packages/react-native-gesture-handler/android/src/main/java/com/swmansion/gesturehandler/react/RNGestureHandlerRootHelper.kt
packages/react-native-gesture-handler/android/src/main/java/com/swmansion/gesturehandler/react/RNGestureHandlerRootView.kt

🚧 Files skipped from review as they are similar to previous changes (5)

packages/react-native-gesture-handler/android/src/main/java/com/swmansion/gesturehandler/react/RNGestureHandlerRootHelper.kt
packages/react-native-gesture-handler/android/src/main/java/com/swmansion/gesturehandler/react/RNGestureHandlerButtonViewManager.kt
packages/react-native-gesture-handler/android/src/main/java/com/swmansion/gesturehandler/react/RNGestureHandlerRootView.kt
packages/react-native-gesture-handler/android/src/main/java/com/swmansion/gesturehandler/react/RNGestureHandlerDetectorView.kt
packages/react-native-gesture-handler/android/src/main/java/com/swmansion/gesturehandler/core/GestureHandlerOrchestrator.kt

📝 Walkthrough

Summary by CodeRabbit

Bug Fixes
- Improved gesture cancellation when native views request disallowing touch interception.
- Prevented stale gesture handlers from remaining active during touch transitions.
- Improved gesture-handler root detection, including handling disabled roots.
- Updated legacy gesture handling to cancel applicable handlers and clean them up reliably.
- Improved touch behavior when switching between native views and gesture handlers.

Walkthrough

The Android gesture-handler implementation now exposes orchestrator state, centralizes legacy-handler cancellation, and cancels attached handlers during disallowed touch interception. Root lookup now prefers enabled gesture-handler roots.

Changes

Native interception cancellation

Layer / File(s)	Summary
Orchestrator cancellation API `packages/react-native-gesture-handler/android/src/main/java/com/swmansion/gesturehandler/core/GestureHandlerOrchestrator.kt`	`isHandlingTouch` is publicly readable. `cancelAllLegacyHandlers()` cancels legacy handlers and schedules cleanup.
Root helper integration `packages/react-native-gesture-handler/android/src/main/java/com/swmansion/gesturehandler/react/RNGestureHandlerRootHelper.kt`	The root helper exposes its orchestrator, registers the JS handler with `ACTION_TYPE_NONE`, uses the new cancellation method, and removes the obsolete local helper.
Interception entry points and root lookup `packages/react-native-gesture-handler/android/src/main/java/com/swmansion/gesturehandler/react/RNGestureHandlerRootView.kt`, `packages/react-native-gesture-handler/android/src/main/java/com/swmansion/gesturehandler/react/RNGestureHandlerDetectorView.kt`, `packages/react-native-gesture-handler/android/src/main/java/com/swmansion/gesturehandler/react/RNGestureHandlerButtonViewManager.kt`	Views propagate active disallow-intercept requests and cancel attached handlers when the orchestrator is not handling touch events. Root lookup prefers enabled roots.

Sequence Diagram(s)

sequenceDiagram
  participant ButtonViewGroup
  participant RNGestureHandlerDetectorView
  participant RNGestureHandlerRootView
  participant GestureHandlerOrchestrator
  ButtonViewGroup->>RNGestureHandlerDetectorView: requestDisallowInterceptTouchEvent(true)
  RNGestureHandlerDetectorView->>RNGestureHandlerRootView: find gesture-handler root
  RNGestureHandlerRootView->>GestureHandlerOrchestrator: read isHandlingTouch
  RNGestureHandlerDetectorView->>GestureHandlerOrchestrator: cancel attached handlers

🚥 Pre-merge checks | ✅ 3

✅ Passed checks (3 passed)

Check name	Status	Explanation
Title check	✅ Passed	The title clearly identifies the Android v3 changes to requestDisallowInterceptTouchEvent, which is the primary focus of the pull request.
Linked Issues check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check	✅ Passed	Check skipped because no linked issues were found for this pull request.

_{Comment @coderabbitai help to get the list of available commands.}

…m/swmansion/gesturehandler/react/RNGestureHandlerDetectorView.kt Co-authored-by: Michał Bert <63123542+m-bert@users.noreply.github.com>

…e touch (#4441) ## Description `Pressable` without relation props presses natively through `ButtonViewGroup`, whose managed `NativeViewGestureHandler` is attached with `ACTION_TYPE_NONE`. RNGH delivers touches through the orchestrator regardless of what happens in the native dispatch, so when a native `ScrollView` takes the gesture over, nothing stops the handler - it reaches `STATE_END` on lift and fires a press. This shows up in three ways: - fling catch: the `ScrollView` intercepts `DOWN` while decelerating, the button never sees any native event, yet `onPress` fires on lift (#4432) - drag: the `ScrollView` intercepts on `MOVE` when the finger starts scrolling from a row, and `onPress` still fires on lift ([comment](#4432 (comment))) - long press while scrolling: the content moves with the finger, so the pointer never leaves the row and the long-press timer posted on `BEGAN` fires mid-scroll (same comment) In all three the `ScrollView` calls `requestDisallowInterceptTouchEvent(true)`, but the existing sweep (`cancelAllLegacyHandlers`) only cancels action-driven handlers, and the `ButtonViewGroup` override from #4367 never runs since the request only bubbles up from the `ScrollView`. Cancelling button handlers directly at request time (the #4433 approach) is not valid either: an eager disallow-intercept (`react-native-pager-view`'s `NestedScrollableHost` requests it on `DOWN` whenever it's nested inside another `ViewPager`, without intercepting anything) is indistinguishable from a real interception at that moment, so every `Pressable` inside nested pagers (e.g. material top tabs in a pager) would go dead - the regression class #4367 fixed. The two can be told apart by when the grab happened and whether the native dispatch still reached the button: - `ButtonViewGroup` tracks `receivedNativeDown` - set in `dispatchTouchEvent` (handler delivery bypasses it), reset on `BEGAN`, which the orchestrator dispatches before the native dispatch of the same `DOWN`. - `RNGestureHandlerRootHelper` records the disallow request, and once the root view finishes `super.dispatchTouchEvent` runs `cancelHandlersOnNativeTouchGrab`, cancelling handlers whose hook opts in. - The hook decides via `shouldCancelOnNativeTouchGrab(grabbedMidGesture) = grabbedMidGesture || !receivedNativeDown`: a grab on any pass after `DOWN` means actual dragging (cancel, matching what the legacy `Pressable` and RN's `Pressable` do), while a grab during the `DOWN` pass spares a button that received that `DOWN` (a defensive disallow lets the event through). Only `ButtonViewGroup` opts into the hook, so handlers attached to detectors, scrollables and text inputs are unaffected. The cost on passes without a disallow request is a single boolean check. Fixes #4432 Supersedes #4433 ## Test plan Repro below: a `SectionList` with `Pressable` rows (`onPress` + `onLongPress`), a `Pressable` and a long-press `GestureDetector` inside nested `PagerView`s (the eager-disallow setup from #2383), and an engine toggle (v3 / `LegacyPressable` / RN `Pressable`). All runs on the same emulator, main vs this PR: | scenario | main | this PR | | --- | --- | --- | | fling the list, touch a row to stop it, lift | phantom `onPress` | nothing | | put a finger on a row and drag-scroll, lift | phantom `onPress` | nothing | | hold a row while drag-scrolling past 500 ms | phantom `onLongPress` | nothing | | tap a row on a settled list | `onPress` | `onPress` | | stationary long press on a row | `onLongPress` | `onLongPress` | | tap the `Pressable` inside nested pagers | `onPress` | `onPress` | | long press the detector box inside nested pagers (#2383) | activates | activates | `LegacyPressable` behaves the same in the list scenarios; inside nested pagers it doesn't fire on main either - its handlers are cancelled on any disallow-intercept request, which is the pre-existing legacy behavior this PR doesn't change. RN's `Pressable` doesn't go through RNGH and is clean everywhere. <details> <summary>Repro</summary> ```tsx import React, { useState } from 'react'; import { Pressable as RNPressable, SectionList, StyleSheet, Text, View, } from 'react-native'; import PagerView from 'react-native-pager-view'; import { GestureDetector, LegacyPressable, Pressable, useLongPressGesture, } from 'react-native-gesture-handler'; const SECTIONS = Array.from({ length: 8 }, (_, section) => ({ title: `Section ${section}`, data: Array.from({ length: 10 }, (_, index) => `Item ${section}-${index}`), })); const ENGINES = ['Pressable (v3)', 'LegacyPressable', 'RN Pressable'] as const; const COMPONENTS = [Pressable, LegacyPressable, RNPressable] as const; function LongPressBox({ onLongPress }: { onLongPress: () => void }) { const longPress = useLongPressGesture({ runOnJS: true, onActivate: onLongPress, }); return ( <GestureDetector gesture={longPress}> <View style={styles.gestureBox} /> </GestureDetector> ); } export default function EmptyExample() { const [engine, setEngine] = useState(0); const [lastEvent, setLastEvent] = useState('none'); const [eventCount, setEventCount] = useState(0); const Row = COMPONENTS[engine] as typeof Pressable; const report = (kind: string, item: string) => { setLastEvent(`${kind} ${item}`); setEventCount((count) => count + 1); }; return ( <View style={styles.root}> <View style={styles.banner}> <Text style={styles.bannerText}>engine: {ENGINES[engine]}</Text> <Text style={styles.bannerText}> last: {lastEvent} (count: {eventCount}) </Text> <Pressable style={styles.toggle} onPress={() => { setEngine((current) => (current + 1) % ENGINES.length); setLastEvent('none'); setEventCount(0); }}> <Text style={styles.toggleText}>Toggle engine</Text> </Pressable> </View> {/* Nested pagers: the inner pager's NestedScrollableHost calls requestDisallowInterceptTouchEvent(true) on ACTION_DOWN only when it sits inside another ViewPager2 — the eager-disallow case from #4367. */} <PagerView style={styles.pager} initialPage={0}> <View key="outer-a" style={styles.page}> <PagerView style={styles.innerPager} initialPage={0}> <View key="a" style={[styles.page, styles.pageRow]}> <Row style={styles.pagerButton} onPress={() => report('press', 'pager-button')}> <Text style={styles.toggleText}>Pager button</Text> </Row> {/* The #2383 setup: a long-press gesture inside nested pagers (material top tabs are pager-view underneath). */} <LongPressBox onLongPress={() => report('gesture', 'pager-box')} /> </View> <View key="b" style={styles.page}> <Text>Page B</Text> </View> </PagerView> </View> <View key="outer-b" style={styles.page}> <Text>Outer page B</Text> </View> </PagerView> <SectionList sections={SECTIONS} keyExtractor={(item) => item} renderSectionHeader={({ section }) => ( <Text style={styles.sectionHeader}>{section.title}</Text> )} renderItem={({ item }) => ( <Row style={styles.row} onPress={() => report('press', item)} onLongPress={() => report('longPress', item)}> <Text>{item}</Text> </Row> )} /> </View> ); } const styles = StyleSheet.create({ root: { flex: 1, }, banner: { padding: 16, gap: 8, backgroundColor: '#eee', }, bannerText: { fontWeight: 'bold', }, toggle: { alignSelf: 'flex-start', paddingVertical: 8, paddingHorizontal: 16, borderRadius: 8, backgroundColor: 'steelblue', }, toggleText: { color: 'white', }, sectionHeader: { paddingHorizontal: 24, paddingVertical: 8, fontWeight: 'bold', backgroundColor: '#ddd', }, row: { padding: 24, borderBottomWidth: 1, borderBottomColor: '#ddd', }, pager: { height: 110, borderBottomWidth: 2, borderBottomColor: '#bbb', }, page: { alignItems: 'center', justifyContent: 'center', }, pageRow: { flexDirection: 'row', gap: 16, }, gestureBox: { width: 64, height: 44, borderRadius: 8, backgroundColor: 'crimson', }, innerPager: { alignSelf: 'stretch', flex: 1, }, pagerButton: { paddingVertical: 12, paddingHorizontal: 24, borderRadius: 8, backgroundColor: 'darkorange', }, }); ``` </details>

Copilot AI review requested due to automatic review settings July 30, 2026 13:21

Copilot started reviewing on behalf of j-piasecki July 30, 2026 13:22 View session

Copilot AI reviewed Jul 30, 2026

View reviewed changes

j-piasecki force-pushed the jpiasecki/handle-request-disallow branch 3 times, most recently from 934af71 to c30a19c Compare July 31, 2026 09:25

j-piasecki marked this pull request as ready for review July 31, 2026 11:34

m-bert approved these changes Jul 31, 2026

View reviewed changes

Comment thread ...ler/android/src/main/java/com/swmansion/gesturehandler/react/RNGestureHandlerDetectorView.kt Outdated

j-piasecki and others added 3 commits August 3, 2026 08:32

[Android] Properly handle requestDisallowInterceptTouchEvent for v3

98972fa

Update packages/react-native-gesture-handler/android/src/main/java/co…

f51fd31

…m/swmansion/gesturehandler/react/RNGestureHandlerDetectorView.kt Co-authored-by: Michał Bert <63123542+m-bert@users.noreply.github.com>

Format

dc49bcc

j-piasecki force-pushed the jpiasecki/handle-request-disallow branch from dd2e6bc to dc49bcc Compare August 3, 2026 06:36

j-piasecki merged commit f0c98c7 into main Aug 3, 2026
4 checks passed

j-piasecki deleted the jpiasecki/handle-request-disallow branch August 3, 2026 07:30

coderabbitai Bot mentioned this pull request Aug 6, 2026

[Android] Add hover callbacks to Touchable #4396

Merged

coderabbitai Bot mentioned this pull request Aug 17, 2026

fix(Android): cancel button handlers when a native view takes the touch lock #4433

Closed

This was referenced Aug 18, 2026

[Android] Fix buttons firing press events when a scroll takes over the touch #4441

Merged

[Android] Pressable fires onPress when the touch only stops a fling #4432

Closed

kaloudis mentioned this pull request Aug 25, 2026

chore(deps): bump react-native to 0.86.0 ZeusLN/zeus#4185

Merged

29 tasks

Navigation Menu

Uh oh!

Uh oh!

[Android] Properly handle `requestDisallowInterceptTouchEvent` for v3 - #4367

[Android] Properly handle `requestDisallowInterceptTouchEvent` for v3#4367
j-piasecki merged 3 commits into
mainfrom
jpiasecki/handle-request-disallow

j-piasecki commented Jul 30, 2026 •

edited by coderabbitai Bot

Loading

Uh oh!

Copilot AI left a comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

coderabbitai Bot commented Aug 3, 2026 •

edited

Loading

Summary by CodeRabbit

Walkthrough

Changes

Sequence Diagram(s)

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Uh oh!

Uh oh!

Conversation

j-piasecki commented Jul 30, 2026 • edited by coderabbitai Bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description

Test plan

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Reviewed changes

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

coderabbitai Bot commented Aug 3, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary by CodeRabbit

Walkthrough

Changes

Sequence Diagram(s)

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

j-piasecki commented Jul 30, 2026 •

edited by coderabbitai Bot

Loading

coderabbitai Bot commented Aug 3, 2026 •

edited

Loading